Skip to content

Conversation

@bhandras
Copy link
Contributor

@bhandras bhandras commented Jun 3, 2022

The fix of the retry logic (#1856) missed the return when the http response was nil. This PR fixes this issue.

@coveralls
Copy link

Pull Request Test Coverage Report for Build 2434746092

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 15 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.03%) to 55.037%

Changes Missing Coverage Covered Lines Changed/Added Lines %
rpcclient/infrastructure.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
mempool/mempool.go 1 66.75%
rpcclient/infrastructure.go 1 0%
peer/peer.go 13 73.2%
Totals Coverage Status
Change from base Build 2430954817: -0.03%
Covered Lines: 26438
Relevant Lines: 48037

💛 - Coveralls

Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job

Copy link
Member

@Roasbeef Roasbeef left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🥪

@Roasbeef Roasbeef merged commit 8fc2d70 into btcsuite:master Jun 6, 2022
Roasbeef added a commit to Roasbeef/btcd that referenced this pull request Jun 6, 2022
Includes:
  * A fix in the RPC server: btcsuite#1862
  * Rolling back a breaking change fromteh PoV of the rpcclient: btcsuite#1844
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants