fix: panic when the response is nil #23
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change is copied from btcd@master(718d268) directly
chappjc
reviewed
Mar 29, 2023
| jReq.responseChan <- &Response{ | ||
| err: fmt.Errorf("invalid http POST response (nil), "+ | ||
| "method: %s, id: %d, last error=%v", | ||
| jReq.method, jReq.id, lastErr), |
There was a problem hiding this comment.
Looks like this diff did not cherry-pick cleanly. Some prerequisite commits were not included:
btcsuite#1856 and btcsuite#1862 both preceeded this
This was referenced Mar 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It doesn panic sometimes, this change is copied from btcd@master(718d268) directly. Should be able to merge without risk.