Skip to content

Support for riscv64#781

Merged
saudet merged 9 commits into
bytedeco:masterfrom
ixgbe00:master
Nov 22, 2024
Merged

Support for riscv64#781
saudet merged 9 commits into
bytedeco:masterfrom
ixgbe00:master

Conversation

@ixgbe00
Copy link
Copy Markdown
Contributor

@ixgbe00 ixgbe00 commented Oct 10, 2024

Support for riscv64 on LinuxOS

@saudet
Copy link
Copy Markdown
Member

saudet commented Oct 10, 2024

Please also update the workflow and update the GitHut Actions scripts to support that platform

@saudet
Copy link
Copy Markdown
Member

saudet commented Oct 10, 2024

You'll need to update this first:
https://github.com/bytedeco/javacpp-presets/tree/master/.github/actions/deploy-ubuntu

@ixgbe00
Copy link
Copy Markdown
Contributor Author

ixgbe00 commented Oct 11, 2024

You'll need to update this first: https://github.com/bytedeco/javacpp-presets/tree/master/.github/actions/deploy-ubuntu

bytedeco/javacpp-presets#1544

saudet
saudet reviewed Oct 12, 2024
View reviewed changes
Comment thread src/main/resources/org/bytedeco/javacpp/properties/linux-riscv64.properties Outdated
@ixgbe00 ixgbe00 requested a review from saudet October 13, 2024 13:07
saudet
saudet requested changes Oct 23, 2024
View reviewed changes
Copy link
Copy Markdown
Member

@saudet saudet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the build pass

@ixgbe00
Copy link
Copy Markdown
Contributor Author

ixgbe00 commented Oct 25, 2024

Please make the build pass
I've researched it for a while, but haven't found any good solutions. Could you give me some advice?

@saudet
Copy link
Copy Markdown
Member

saudet commented Oct 25, 2024

Looks like some issue with Ubuntu's repository for the JDK and riscv64...

@ixgbe00
Copy link
Copy Markdown
Contributor Author

ixgbe00 commented Oct 25, 2024

Looks like some issue with Ubuntu's repository for the JDK and riscv64...

1729841035741
It seems that java-8-openjdk-amd64 is used on ppc64el

@ixgbe00
Copy link
Copy Markdown
Contributor Author

ixgbe00 commented Oct 28, 2024

Looks like some issue with Ubuntu's repository for the JDK and riscv64...

sudo apt install openjdk-11-jdk -y
I can install openjdk-11-jdk on riscv64 platform , but can not install openjdk-8-jdk. Therefore if we can use openidk11 ?
image

@saudet
Copy link
Copy Markdown
Member

saudet commented Oct 28, 2024

I'm not going to accept that until next year, but you can maintain your own fork until then I guess

@saudet
Copy link
Copy Markdown
Member

saudet commented Oct 28, 2024 •
edited
Loading

We can merge changes that don't affect the CI though. However, please fix the formatting before we do that.

@ixgbe00
Copy link
Copy Markdown
Contributor Author

ixgbe00 commented Oct 28, 2024

I'm not going to accept that until next year, but you can maintain your own fork until then I guess

I get it.Thanks for your advice.

@ixgbe00 ixgbe00 requested a review from saudet November 21, 2024 07:42
saudet
saudet reviewed Nov 21, 2024
View reviewed changes
Comment thread platform/pom.xml Outdated
@ixgbe00 ixgbe00 requested a review from saudet November 22, 2024 01:36
@saudet saudet merged commit 27d1be5 into bytedeco:master Nov 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@saudet saudet saudet approved these changes

Assignees

No one assigned

Labels

enhancement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ixgbe00 @saudet