Repository navigation
Conversation
Signed-off-by: denesbeck <denes.beck1@outlook.com>
Contributor
Changed Packages
|
Sarabadu
approved these changes
Oct 7, 2026
Sarabadu
left a comment
Contributor
There was a problem hiding this comment.
Looks good, Thanks @denesbeck !!
The loosing of the "selected" entity in the title does not look like an issue because the graph its clear enough on the entity we are looking at
Author
Thanks for the review! |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the new frontend system, the catalog graph page rendered its own legacy
Headerunder the app's page layout header, so/catalog-graphshowed two headers. The NFS page now renders only the page content and leaves the header to the layout, which already gets the title and icon from the plugin. The legacyCatalogGraphPageexport is unchanged.The legacy header showed the selected root entities as a subtitle. The plugin header has no subtitle, so that's not shown in NFS.
✔️ Checklist
Signed-off-byline in the message. (more info)