Skip to content

catalog-import: use app page header in NFS - #36068

Open
denesbeck wants to merge 2 commits into
backstage:masterfrom
denesbeck:catalog-import-nfs-header
Open

catalog-import: use app page header in NFS#36068
denesbeck wants to merge 2 commits into
backstage:masterfrom
denesbeck:catalog-import-nfs-header

Conversation

@denesbeck

@denesbeck denesbeck commented Oct 7, 2026 •
edited
Loading

Copy link
Copy Markdown

In the new frontend system, the default catalog import page rendered its own legacy Header under the app's page layout header, so /catalog-import showed two headers. The NFS page now renders the page content directly and leaves the header to the layout. The permission check is unchanged. The legacy CatalogImportPage and DefaultImportPage exports are unchanged.

Note that packages/app mounts the legacy page through convertLegacyAppRoot, so the change is only visible in apps that use @backstage/plugin-catalog-import/alpha.

✔️ Checklist

  • A changeset describing the change and affected packages. (more info)
  • Added or updated documentation
  • Tests for new functionality and regression tests for bug fixes
  • Screenshots attached (for UI changes)
  • All your commits have a Signed-off-by line in the message. (more info)
image

@denesbeck
catalog-import: use app page header in NFS
658ef77 
Signed-off-by: denesbeck <denes.beck1@outlook.com>
@denesbeck
denesbeck requested review from a team as code owners October 7, 2026 19:41
@github-actions github-actions Bot added the area:catalog Related to the Catalog Project Area label Oct 7, 2026
@backstage-goalie

backstage-goalie Bot commented Oct 7, 2026

Copy link
Copy Markdown
Contributor

Changed Packages

Package Name Package Path Changeset Bump Current Version
@backstage/plugin-catalog-import plugins/catalog-import patch v0.13.19-next.0

@backstage-goalie backstage-goalie Bot added size:medium Medium-sized pull requests receive no change in priority for reviews. waiting-for:review The PR needs a review and will be visible in the review queue unless already assigned an owner. labels Oct 7, 2026
Sarabadu
Sarabadu reviewed Oct 7, 2026
View reviewed changes

@Sarabadu Sarabadu left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but I think the page could use the content directly on the NFS page bluprint

Comment thread plugins/catalog-import/src/components/DefaultImportPage/DefaultImportPage.tsx Outdated
Comment thread plugins/catalog-import/src/components/ImportPage/ImportPage.tsx Outdated
Comment thread plugins/catalog-import/src/alpha.tsx Outdated
@denesbeck
catalog-import: render page content directly in NFS
8f343b2 
Signed-off-by: denesbeck <denes.beck1@outlook.com>
@denesbeck

denesbeck commented Oct 8, 2026

Copy link
Copy Markdown
Author

Thanks for the review. The NFS page blueprint now renders ImportPageContent directly inside RequirePermission, and the header variant and outlet are gone from the NFS path. DefaultImportPage is the legacy Page + Header around the same content, so the legacy output is unchanged.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer
@Sarabadu Sarabadu Sarabadu left review comments
Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

area:catalog Related to the Catalog Project Area size:medium Medium-sized pull requests receive no change in priority for reviews. waiting-for:review The PR needs a review and will be visible in the review queue unless already assigned an owner.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denesbeck @Sarabadu