Repository navigation
fix Babel 8 commander import - #16548
Merged
Merged
Conversation
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57108 |
nicolo-ribaudo
approved these changes
Jun 4, 2024
nicolo-ribaudo
left a comment
Member
There was a problem hiding this comment.
I'll release a new alpha
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the Babel 8 test in #16517 was passing because we the condition proxy package is marked as CJS only, as we did not specify the esm exports for the
commanderpackage. The commander v12 is a dual package, so essentially we were importing a CJS wrapper of commander, which breaks Babel 8 since the ESM version should be used.Idea for the yarn conditional plugin: make the
esmcondition clause required when some of dependents are dual / esm-only packages, otherwise users end up using CJS wrappers of those packages.