Skip to content

[Babel 8] fix: Throwing exceptions synchronously - #16836

Merged
JLHwung merged 1 commit into
babel:mainfrom
liuxingbaoyu:cjs-proxy
Sep 16, 2024
Merged

[Babel 8] fix: Throwing exceptions synchronously#16836
JLHwung merged 1 commit into
babel:mainfrom
liuxingbaoyu:cjs-proxy

Conversation

@liuxingbaoyu

@liuxingbaoyu liuxingbaoyu commented Sep 13, 2024 •
edited
Loading

Copy link
Copy Markdown
Member
Q 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 聽 A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Not only was it previously impossible to catch, the stack had almost no useful content.
Ref: babel/website#2961

file:///F:/git/website/node_modules/@babel/core/lib/config/index.js:22
      throw new Error("Starting from Babel 8.0.0, the 'loadPartialConfig' function expects a callback. If you need to call it synchronously, please use 'loadPartialConfigSync'.");
            ^

Error: Starting from Babel 8.0.0, the 'loadPartialConfig' function expects a callback. If you need to call it synchronously, please use 'loadPartialConfigSync'.
    at Module.loadPartialConfig (file:///F:/git/website/node_modules/@babel/core/lib/config/index.js:22:13)
    at F:\git\website\node_modules\@babel\core\cjs-proxy.cjs:33:18

@liuxingbaoyu liuxingbaoyu changed the title fix: Throwing exceptions synchronously [Babel 8] fix: Throwing exceptions synchronously Sep 13, 2024
@babel-bot

babel-bot commented Sep 13, 2024

Copy link
Copy Markdown
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/57943

@JLHwung JLHwung added the PR: Polish (next major) 馃拝 A type of pull request used for our changelog categories for next major release label Sep 16, 2024
@JLHwung
JLHwung merged commit cd8ffa4 into babel:main Sep 16, 2024
@github-actions github-actions Bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 17, 2024
@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Dec 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees

No one assigned

Labels

outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish (next major) 馃拝 A type of pull request used for our changelog categories for next major release

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@liuxingbaoyu @babel-bot @nicolo-ribaudo @JLHwung