Repository navigation
Conversation
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @nyan-left. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
Insufficient dataNot enough activity yet to make a reliable assessment. This is an automated analysis by AgentScan |
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62305 |
|
commit: |
|
You have violated the AI policy of the Babel project without a declaimer that this PR is generated by LLM. |
Fair. I marked the LLM assistance on the issue but not here. I've now read the AI policy properly. PR descriptions have to be my own writing, a disclaimer wouldn't have covered it either way. How do you want to handle it? I can rewrite the description and the tests by hand, or close this and leave the issue up with the repro. Either is fine, your call. |
|
@nicolo-ribaudo I was clearly trying to sort this out. I owned up to it and asked how maintainers wanted to handle it. Even offered to rewrite the description and tests myself. Three weeks of nothing, then a label and a close without a word. If closing it was the answer, a one line reply would have done it. Kind of ridiculous when the fix is sitting right there and it's easy to follow. If you want to fix it yourselves and cherry-pick the exact same code, feel free. I've patched it locally anyway and I'm moving off Babel as soon as I can. |
|
Sorry about that, I was going through PRs to close and didn't notice that this was pending on us to reply. There is clearly enough human involvement on your side, I'll review. |
|
Any chance you could restore the branch so that I can reopen the PR, or can you re-submit it? |
|
@nicolo-ribaur It's okay. Will restore tomorrow AM, once I'm back at my desk. Thanks. |
|
Hey @nicolo-ribaudo , that has been restored. LMK if you'd like the tests rewritten/tweaked or if you have any other feedback. Thank you. |
nicolo-ribaudo
left a comment
There was a problem hiding this comment.
Thank you! Can you also add input/output tests next to the exec ones?
|
Btw, do you need this PR backported to v7 also? |
|
Yeah, we're using v7. Restored the branch on that PR. #18225 |
Decorator memoization can be attached to a class field that a later transform removes, causing the generated class to throw
TypeError: A decorator must be a function.This skips removable fields when selecting a host and uses the existing temporary computed field when necessary, and this is obviously going to solve the problem without changing decorator evaluation order.
Regression tests cover uninitialized and declaration fields.