Skip to content

Fix eslint-parser AST definition of AccessorProperty #18257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nicolo-ribaudo merged 2 commits into from
Sep 30, 2026
Merged

Fix eslint-parser AST definition of AccessorProperty #18257

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8e0c9fa
Fix eslint-parser AccessorProperty template parsing (#18230)
jpradelle Sep 28, 2026
e5a6e70
Fix for pull request #18257
jpradelle Sep 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions eslint/babel-eslint-parser/src/ast-info.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,7 @@ export function getVisitorKeys() {
if (!visitorKeys) {
// AST Types that are not presented in Babel AST
const newTypes = {
AccessorProperty: ["decorators", "typeAnnotation", "value", "key"],
ChainExpression: ESLINT_VISITOR_KEYS.ChainExpression,
ImportExpression: ESLINT_VISITOR_KEYS.ImportExpression,
Literal: ESLINT_VISITOR_KEYS.Literal,
Expand Down
7 changes: 7 additions & 0 deletions eslint/babel-eslint-parser/test/typescript-estree.test.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -460,4 +460,11 @@ describe("Babel should output the same AST as TypeScript-Estree", () => {
}
}
});

describe("templates", () => {
// This test needs typescript-estree, espree doesn't support AccessorProperty
it("template element ranges inside accessor property #18230", () => {
parseAndAssertSame("class T { accessor a = `x${y}z`; }");
});
});
});
Loading