Repository navigation
Conversation
… by `of` Per LexicalBinding early errors, a binding without an Initializer is only allowed in the head of a `for-in`/`for-of` statement. `parseVar` skipped the error whenever the next token was `in` or `of`, even outside a for head, so e.g. `const x\nof` was parsed as `const x; of;`. Assisted-by: Claude Opus 5.5 <noreply@anthropic.com>
esprima/statement-iteration/const_forin duplicates packages/babel-parser/test/fixtures/es2015/for-in/const-no-initializer uncategorised/315 duplicate packages/babel-parser/test/fixtures/es2015/for-of/const-no-initializer
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62373 |
JLHwung
commented
Oct 12, 2026
| ); | ||
| } else if ( | ||
| (kind === "const" || kind === "using" || kind === "await using") && | ||
| !(this.match(tt._in) || this.isContextual(tt._of)) |
Contributor
Author
There was a problem hiding this comment.
The input
const x
ofwas incorrectly allowed because here we perform a lookahead without checking the isFor context. This PR fixes this issue by moving the isFor + in/of check upfront to the !allowMissingInitializer and simplify the logic flow.
|
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this PR we fix an issue reported by Claude Code, see comments below for an detailed explanation.
I prompted the LLM to add more tests and have reviewed the add new tests.