Repository navigation
Conversation
transform-block-scoping lowers a nested `for (let x = ...)` to `var`, so a closure created inside that initializer captured one function-scoped binding across every iteration of the enclosing loop. The loop-body binding collector skipped nested loops entirely, so the enclosing loop never learned that its body needed a per-iteration wrapper. Collect a nested ForStatement's let/const head bindings when a closure in its initializer captures them, so the enclosing loop wraps its body and each entry of the nested loop gets a fresh binding. The existing for-head-closure-nested fixture now asserts the spec result instead of the TODO. Fixes babel#18200 Assisted-by: Claude Fable 5.1
Thanks for opening this pull request! 🎉We really appreciate you taking the time to contribute, @Marve10s. A maintainer will take a look as soon as they can. In the meantime, please make sure that:
If anything needs adjusting we'll leave comments here. Thanks again! |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Collaborator
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/62374 |
|
commit: |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The loop-body binding collector skipped nested loops, so a closure in a nested
for (let x = ...)initializer captured one sharedxacross iterations of the enclosing loop. The collector now reports those head bindings when the initializer captures them, so the enclosing loop gets its per-iteration wrapper, and the existingfor-head-closure-nestedfixture drops its TODO and asserts[0, 1].