Conversation
arogge
approved these changes
Jan 4, 2024
sebsura
force-pushed
the
backport/bareos-23/fix-cancel-handling-crash
branch
from
January 5, 2024 11:18
42c039c to
b19597d
Compare
(cherry picked from commit 4a5fdf0)
(cherry picked from commit 9445794)
Each seperate thread needs its own python thread state to do things inside of python. (cherry picked from commit 6efcfe0)
The new test tries to cancel the job while the job is inside the plugin module. This is to check whether there are any crashes. (cherry picked from commit e1f245c)
This allows us to test what happens if the plugin finishes the backup while the cancelation is still ongoing. (cherry picked from commit 3baa043)
This prevents the situation where one thread is still trying to cancel something while another is already destroying parts of the jcr. (cherry picked from commit 9f99ee3)
(cherry picked from commit 77db4af)
(cherry picked from commit 3e5432e)
(cherry picked from commit eadb837)
On windows one hase to use ::closesocket() instead of ::close() to close sockets. See: bsock_tcp.cc:50-58 (cherry picked from commit 91c1229)
(cherry picked from commit c9a0e16)
(cherry picked from commit cb724e4)
(cherry picked from commit d933d5d)
sebsura
force-pushed
the
backport/bareos-23/fix-cancel-handling-crash
branch
from
January 5, 2024 11:40
b19597d to
838dae1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
Backport of PR #1595 to bareos-23
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
Make sure you check/merge the PR using
devtools/pr-toolto have some simple automated checks run and a proper changelog record added.General
Source code quality
Tests