Skip to content

core: add build patch for sprintf in macos builds - #1651

Merged
BareosBot merged 3 commits into
bareos:bareos-23from
sebsura:backport/bareos-23/patch-macos-build
Jan 10, 2024
Merged

core: add build patch for sprintf in macos builds#1651
BareosBot merged 3 commits into
bareos:bareos-23from
sebsura:backport/bareos-23/patch-macos-build

Conversation

@sebsura

@sebsura sebsura commented Jan 5, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Thank you for contributing to the Bareos Project!

Backport of PR #1636 to bareos-23

Fix build issues on macos

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

@sebsura
sebsura force-pushed the backport/bareos-23/patch-macos-build branch from dc75d2c to edbd02d Compare January 10, 2024 13:03
bruno-at-bareos
bruno-at-bareos approved these changes Jan 10, 2024
View reviewed changes

@bruno-at-bareos bruno-at-bareos left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the good works. Approved

chenrui333 and others added 3 commits January 10, 2024 15:46
@chenrui333 @BareosBot
core: add build patch for sprintf in macos builds
0d12193 
sprintf is marked deprecated on mac.

Signed-off-by: Rui Chen <rui@chenrui.dev>
(cherry picked from commit e38f67e)
@sebsura @BareosBot
authors: add rui chen to authors file
3948c0c 
(cherry picked from commit 2035805)
@BareosBot
Update CHANGELOG.md
afdb9f7
@BareosBot
BareosBot force-pushed the backport/bareos-23/patch-macos-build branch from 76b08dd to afdb9f7 Compare January 10, 2024 15:46
@BareosBot
BareosBot merged commit 0245874 into bareos:bareos-23 Jan 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@bruno-at-bareos bruno-at-bareos bruno-at-bareos approved these changes

Assignees

No one assigned

Labels

is a backport to 23

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@sebsura @bruno-at-bareos @BareosBot @chenrui333