Skip to content

Fix bareos_tasks plugin for pgsql - #1660

Merged
BareosBot merged 5 commits into
bareos:bareos-23from
joergsteffens:dev/joergs/bareos-23/tasks
Jan 12, 2024
Merged

BareosBot merged 5 commits into
bareos:bareos-23from
joergsteffens:dev/joergs/bareos-23/tasks

Conversation

@joergsteffens

@joergsteffens joergsteffens commented Jan 10, 2024

Copy link
Copy Markdown
Member

Fix bareos_tasks plugin for pgsqlThe pgsql plugin from bareos_tasks is currently not working at all. There were a few errors which are now fixed and the plugin was testing and working properly on a few test machines.

Backport of PR #1659 to bareos-23

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

General
  • Is the PR title usable as CHANGELOG entry?
  • Purpose of the PR is understood
  • Commit descriptions are understandable and well formatted
  • Check backport line
  • Required backport PRs have been created
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
Tests
  • Decision taken that a test is required (if not, then remove this paragraph)
  • The choice of the type of test (unit test or systemtest) is reasonable
  • Testname matches exactly what is being tested
  • On a fail, output of the test leads quickly to the origin of the fault

@sebsura sebsura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. I found some small issues.

Comment thread AUTHORS Outdated
Comment thread contrib/fd-plugins/bareos_tasks/pgsql/README.md Outdated
Comment thread contrib/fd-plugins/bareos_tasks/pgsql/BareosFdPgSQLClass.py Outdated
@joergsteffens
joergsteffens force-pushed the dev/joergs/bareos-23/tasks branch from a27f830 to 5ce027d Compare January 11, 2024 09:37
@joergsteffens
joergsteffens requested a review from sebsura January 11, 2024 09:39

@sebsura sebsura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

jogoossens and others added 5 commits January 12, 2024 07:20
Fix reading stderr and encoding issues.

(cherry picked from commit 7944529)
and pg_port.

(cherry picked from commit fd11356)
(cherry picked from commit b81240b)
@BareosBot
BareosBot force-pushed the dev/joergs/bareos-23/tasks branch from e57d665 to b23b459 Compare January 12, 2024 07:20
@BareosBot
BareosBot merged commit c9e7d28 into bareos:bareos-23 Jan 12, 2024
@joergsteffens
joergsteffens deleted the dev/joergs/bareos-23/tasks branch April 15, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants