Skip to content

VMware Plugin: Backup and Restore NVRAM - #1733

Merged
BareosBot merged 2 commits into
bareos:bareos-23from
sduehr:backport/bareos-23/vmware-enhancements-2024MarchI
Mar 28, 2024
Merged

BareosBot merged 2 commits into
bareos:bareos-23from
sduehr:backport/bareos-23/vmware-enhancements-2024MarchI

Conversation

@sduehr

@sduehr sduehr commented Mar 12, 2024

Copy link
Copy Markdown
Member

Backport of PR #1727 to bareos-23

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

@bruno-at-bareos
bruno-at-bareos requested a review from pstorz March 19, 2024 10:49
@sduehr
sduehr force-pushed the backport/bareos-23/vmware-enhancements-2024MarchI branch from 1c88b71 to 9682d85 Compare March 21, 2024 16:35
sduehr and others added 2 commits March 28, 2024 09:21
The NVRAM of VMs is now backed up and restored when a VM is recreated.
This ensures that EFI enabled VMs will boot successfully.

Additionally, the exception handling and error messages in the functions
connect_vmware() and retrieve_vcthumbprint() were enhanced.

The plugin now makes sure to store all files belonging to a recreated VM
in the same directory in VMFS.

This commit also contains some changes to improve the pylint score.

(cherry picked from commit cf9c5eb)
@BareosBot
BareosBot force-pushed the backport/bareos-23/vmware-enhancements-2024MarchI branch from f7a68eb to 80be0c3 Compare March 28, 2024 09:21
@BareosBot
BareosBot merged commit 75e8840 into bareos:bareos-23 Mar 28, 2024
@arogge arogge linked an issue Apr 2, 2024 that may be closed by this pull request
@arogge arogge added this to the 23.0.3 milestone Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

VMware Plugin recreated EFI enabled VMs are not bootable

4 participants