Skip to content

Fix warning about missing delcandidates table in director - #1743

Merged
BareosBot merged 3 commits into
bareos:bareos-23from
arogge:backport/bareos-23/fix-catalog-delcandiates-warning
Apr 10, 2024
Merged

BareosBot merged 3 commits into
bareos:bareos-23from
arogge:backport/bareos-23/fix-catalog-delcandiates-warning

Conversation

@arogge

@arogge arogge commented Mar 20, 2024

Copy link
Copy Markdown
Member

Backport of PR #1721 to bareos-23

Checklist for the reviewer of the PR (will be processed by the Bareos team)

Make sure you check/merge the PR using devtools/pr-tool to have some simple automated checks run and a proper changelog record added.

Source code quality (if there were changes to the original PR)
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR

Backport quality

@arogge arogge added this to the 23.0.3 milestone Apr 2, 2024
@sebsura
sebsura self-requested a review April 3, 2024 09:35

@sebsura sebsura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You backported 23db06e but the right commit is d2ff789 .

Did you backport an old version ?

smarsching and others added 2 commits April 3, 2024 11:46
Pruning jobs would cause the following warning in the output of the
director (e.g. visible through
“systemctl status bareos-director.service”):

  table "delcandidates" does not exist, skipping

This warning is harmless but clutters the output. With this commit, this
problem is fixed by disabling warnings for the PostgreSQL connection
that is established by the director.

See https://bugs.bareos.org/view.php?id=1561 and
https://bugs.bareos.org/view.php?id=1606.

(cherry picked from commit 0ac6b2c)
@arogge
arogge force-pushed the backport/bareos-23/fix-catalog-delcandiates-warning branch from 272e947 to f93b4e5 Compare April 3, 2024 09:51

@sebsura sebsura left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like the same to me!

@arogge

arogge commented Apr 5, 2024

Copy link
Copy Markdown
Member Author

@smarsching just in case you weren't aware, this PR is the backport of your changes (and should be merged soon now)

@smarsching

Copy link
Copy Markdown
Contributor

@arogge I wasn’t aware, so thank you for letting me know.

@BareosBot
BareosBot merged commit 3aec0dd into bareos:bareos-23 Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants