Repository navigation
Conversation
mridul89
marked this pull request as ready for review
March 4, 2022 18:19
the test now uses protected method, which is the correct way per laravel documentation
4 tasks done
Contributor
|
@barryvdh I've tested this in our applications and it works perfectly. Could you look into this some time? |
|
@barryvdh can review this PR ? |
Collaborator
|
FTR: this competes with #1339 which covers additional cases and is thus preferred |
Owner
|
I merged #1339 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Laravel introduced a new syntax to define attribute "accessors / mutators" in laravel/framework#40022
Support for this new syntax was added in #1289
However, laravel documentation asks to use protected methods, but #1289 only looked at the public methods. This PR will also include protected methods.
Type of change
Checklist
composer fix-style