Repository navigation
WS-2777: Update inline js for renderers - ReverbTemplate - #14442
Open
alex-magana wants to merge 18 commits into
Open
alex-magana wants to merge 18 commits into
alex-magana wants to merge 18 commits into
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
The new global typings invalidate existing typed mocks, and the new rendering branch lacks test coverage.
Review effort: Balanced
Findings: 1
Open (1)
What changed in this PR
Refactors Reverb bootstrap JavaScript to use the shared inline-script utility.
Changes:
- Extracts the Reverb scaffold into a typed function.
- Adds raw inline-HTML rendering support.
- Defines Reverb promise and timeout globals.
| File | Description |
|---|---|
ws-nextjs-app/renderers/ReverbTemplate.tsx |
Uses addInlineScript for Reverb initialization. |
src/global.d.ts |
Adds Reverb scaffold typings. |
src/app/lib/utilities/addInlineScript/index.tsx |
Adds optional raw script rendering. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
… of github.com:bbc/simorgh into WS-2777-update-inline-js-for-renderers-reverb-template
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves JIRA: WS-2777
Summary
A very high-level summary of easily-reproducible changes that can be understood by non-devs, and why these changes where made.
Code changes
Testing
Useful Links