refuse empty request-target in HTTP request - #3255
Merged
Merged
Conversation
A single slash is valid, but nothing at all can be safely refused. Python stdlib explicitly tells us it will not perform validation. https://docs.python.org/3/library/urllib.parse.html#url-parsing-security There are *four* `request-target` forms in rfc9112, none of them can be empty.
Owner
|
LFTM. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shortest origin-form is a single slash, not empty. So refuse request lines that have two consecutive spaces where the URI should be. There should be something there.
Python stdlib explicitly tells us it will not perform validation - and neither does this patch! This patch merely closes the one trivial hole that is of special interest, as it might confuse setups involving proxies and pipe-lining.