Skip to content

Fixes #1140 ui bug - #1141

Merged
ircfspace merged 5 commits into
bepass-org:mainfrom
Dr-Bad:ui-hotfix
Sep 24, 2025
Merged

ircfspace merged 5 commits into
bepass-org:mainfrom
Dr-Bad:ui-hotfix

Conversation

@Dr-Bad

@Dr-Bad Dr-Bad commented Sep 24, 2025

Copy link
Copy Markdown
Contributor

Change Description

Fixes #1140 ui bug

Checklist

  • Code has been tested.
    • Windows 10
    • Windows 11
    • macOS
    • Linux
  • Relevant documentation has been updated.

Related Links

Bug Report: #1140

@Dr-Bad
Dr-Bad marked this pull request as ready for review September 24, 2025 13:40
@ircfspace

Copy link
Copy Markdown
Collaborator

Thank you for the quick follow-up and the PR you submitted.

Based on my review, there was no need to change the styling.
Also, the setDrawerIsOpen(false) code that was removed caused the app not to close the drawer when starting an update in normal window size.

I’ve reverted the code and replaced it with another solution: calling the handleResize function, which decides whether to close the drawer based on the window size.

The changes have been merged, and I’ll provide a new update soon.
Thanks again.

@ircfspace
ircfspace merged commit 7c7196f into bepass-org:main Sep 24, 2025
@Dr-Bad

Dr-Bad commented Sep 24, 2025

Copy link
Copy Markdown
Contributor Author

@ircfspace At first it wasn't clear for me why it would need to close the drawer but now i understand. but there is still another problem which I'm hopefully going to solve.

@Dr-Bad Dr-Bad mentioned this pull request Sep 24, 2025
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Problem with settings

2 participants