ci: fix CI failures#9
Merged
Merged
Conversation
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 12:31 — with
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 12:51 — with
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 12:52 — with
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 13:05 — with
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 13:26 — with
GitHub Actions
Inactive
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 13:32 — with
GitHub Actions
Inactive
ematipico
force-pushed
the
ci/make-it-work
branch
from
August 17, 2023 15:33
582596d to
d6f5c41
Compare
ematipico
temporarily deployed
to
Website deployment
August 17, 2023 15:33 — with
GitHub Actions
Inactive
jfmcdowell
added a commit
to jfmcdowell/biome
that referenced
this pull request
May 13, 2026
…egression - Quoted lazy continuation: a `>` quote prefix on a continuation line no longer terminates the surrounding paragraph. The terminating-block check is now restricted to unprefixed continuation lines, matching CommonMark. - Split `ordered_marker_non_one_no_interrupt.md` into per-case fixtures (`ordered_marker_non_one_in_bullet_item`, `ordered_marker_one_starts_sublist_in_bullet`, `ordered_marker_non_one_top_level`) per @ematipico's review. - Restore the entity-whitespace fix: numeric character references that decode to whitespace (e.g. `&biomejs#9;` → `\t`) are now preserved across the paragraph close-time trim by tracking entity output ranges out-of-band, restoring 100% CommonMark conformance (652/652).
jfmcdowell
added a commit
to jfmcdowell/biome
that referenced
this pull request
May 13, 2026
…ion lines `strip_paragraph_indent` ran `trim_start()` on each continuation line and stripped whitespace that originated from a decoded numeric entity (e.g. `&biomejs#9;` → `\t`, ` ` → ` `), even though the paragraph buffer already tracks those bytes in `entity_ranges`. Make the helper entity-aware: it now accepts the buffer's entity ranges plus the trimmed slice's offset within the original buffer, and halts the per-line whitespace trim on the first byte that lives inside any preserved range. Structural literal indentation is still stripped as before. Regression tests cover entity-sourced tab, entity-sourced space, and the mixed case where literal leading indent precedes an entity-sourced tab.
jfmcdowell
added a commit
to jfmcdowell/biome
that referenced
this pull request
May 13, 2026
…egression - Quoted lazy continuation: a `>` quote prefix on a continuation line no longer terminates the surrounding paragraph. The terminating-block check is now restricted to unprefixed continuation lines, matching CommonMark. - Split `ordered_marker_non_one_no_interrupt.md` into per-case fixtures (`ordered_marker_non_one_in_bullet_item`, `ordered_marker_one_starts_sublist_in_bullet`, `ordered_marker_non_one_top_level`) per @ematipico's review. - Restore the entity-whitespace fix: numeric character references that decode to whitespace (e.g. `&biomejs#9;` → `\t`) are now preserved across the paragraph close-time trim by tracking entity output ranges out-of-band, restoring 100% CommonMark conformance (652/652).
jfmcdowell
added a commit
to jfmcdowell/biome
that referenced
this pull request
May 13, 2026
…ion lines `strip_paragraph_indent` ran `trim_start()` on each continuation line and stripped whitespace that originated from a decoded numeric entity (e.g. `&biomejs#9;` → `\t`, ` ` → ` `), even though the paragraph buffer already tracks those bytes in `entity_ranges`. Make the helper entity-aware: it now accepts the buffer's entity ranges plus the trimmed slice's offset within the original buffer, and halts the per-line whitespace trim on the first byte that lives inside any preserved range. Structural literal indentation is still stripped as before. Regression tests cover entity-sourced tab, entity-sourced space, and the mixed case where literal leading indent precedes an entity-sourced tab.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PR to fix the failures in the CI (some of them at least)
Test Plan
Make the CI green