Skip to content

ci: fix CI failures#9

Merged
ematipico merged 8 commits into
mainfrom
ci/make-it-work
Aug 17, 2023
Merged

ci: fix CI failures#9
ematipico merged 8 commits into
mainfrom
ci/make-it-work

Conversation

@ematipico

Copy link
Copy Markdown
Member

Summary

PR to fix the failures in the CI (some of them at least)

Test Plan

Make the CI green

@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 12:31 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 12:51 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 12:52 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 13:05 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 13:26 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 13:32 — with GitHub Actions Inactive
@ematipico
ematipico temporarily deployed to Website deployment August 17, 2023 15:33 — with GitHub Actions Inactive
@ematipico
ematipico merged commit 54e85a2 into main Aug 17, 2023
@ematipico
ematipico deleted the ci/make-it-work branch August 17, 2023 15:35
dyc3 added a commit that referenced this pull request Mar 22, 2026
jfmcdowell added a commit to jfmcdowell/biome that referenced this pull request May 13, 2026
…egression

- Quoted lazy continuation: a `>` quote prefix on a continuation line no
  longer terminates the surrounding paragraph. The terminating-block
  check is now restricted to unprefixed continuation lines, matching
  CommonMark.
- Split `ordered_marker_non_one_no_interrupt.md` into per-case fixtures
  (`ordered_marker_non_one_in_bullet_item`,
  `ordered_marker_one_starts_sublist_in_bullet`,
  `ordered_marker_non_one_top_level`) per @ematipico's review.
- Restore the entity-whitespace fix: numeric character references that
  decode to whitespace (e.g. `&biomejs#9;` → `\t`) are now preserved across
  the paragraph close-time trim by tracking entity output ranges
  out-of-band, restoring 100% CommonMark conformance (652/652).
jfmcdowell added a commit to jfmcdowell/biome that referenced this pull request May 13, 2026
…ion lines

`strip_paragraph_indent` ran `trim_start()` on each continuation line and
stripped whitespace that originated from a decoded numeric entity (e.g.
`&biomejs#9;` → `\t`, ` ` → ` `), even though the paragraph buffer already
tracks those bytes in `entity_ranges`. Make the helper entity-aware: it
now accepts the buffer's entity ranges plus the trimmed slice's offset
within the original buffer, and halts the per-line whitespace trim on the
first byte that lives inside any preserved range. Structural literal
indentation is still stripped as before.

Regression tests cover entity-sourced tab, entity-sourced space, and the
mixed case where literal leading indent precedes an entity-sourced tab.
jfmcdowell added a commit to jfmcdowell/biome that referenced this pull request May 13, 2026
…egression

- Quoted lazy continuation: a `>` quote prefix on a continuation line no
  longer terminates the surrounding paragraph. The terminating-block
  check is now restricted to unprefixed continuation lines, matching
  CommonMark.
- Split `ordered_marker_non_one_no_interrupt.md` into per-case fixtures
  (`ordered_marker_non_one_in_bullet_item`,
  `ordered_marker_one_starts_sublist_in_bullet`,
  `ordered_marker_non_one_top_level`) per @ematipico's review.
- Restore the entity-whitespace fix: numeric character references that
  decode to whitespace (e.g. `&biomejs#9;` → `\t`) are now preserved across
  the paragraph close-time trim by tracking entity output ranges
  out-of-band, restoring 100% CommonMark conformance (652/652).
jfmcdowell added a commit to jfmcdowell/biome that referenced this pull request May 13, 2026
…ion lines

`strip_paragraph_indent` ran `trim_start()` on each continuation line and
stripped whitespace that originated from a decoded numeric entity (e.g.
`&biomejs#9;` → `\t`, ` ` → ` `), even though the paragraph buffer already
tracks those bytes in `entity_ranges`. Make the helper entity-aware: it
now accepts the buffer's entity ranges plus the trimmed slice's offset
within the original buffer, and halts the per-line whitespace trim on the
first byte that lives inside any preserved range. Structural literal
indentation is still stripped as before.

Regression tests cover entity-sourced tab, entity-sourced space, and the
mixed case where literal leading indent precedes an entity-sourced tab.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant