feat(lint/js): add noRestrictedProperties - #9806
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: bf82af3 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
dyc3
force-pushed
the
dyc3/noRestrictedProperties
branch
from
April 5, 2026 16:18
ccb0e3c to
00f25c4
Compare
dyc3
marked this pull request as ready for review
April 5, 2026 16:27
Contributor
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
WalkthroughAdds ESLint Possibly related PRs
Suggested labels: Suggested reviewers: 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
dyc3
force-pushed
the
dyc3/noRestrictedProperties
branch
from
April 6, 2026 13:52
00f25c4 to
2d32061
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/biome_js_analyze/src/lint/nursery/no_restricted_properties.rs (1)
265-277: Minor: Redundantomit_parentheses()call.Line 270 calls
omit_parentheses()on the object, butidentifier_object_name(line 416) calls it again internally. The first call is redundant sinceidentifier_object_namehandles it.Not blocking – the duplication is harmless and keeps
identifier_object_nameself-contained for other call sites (lines 382, 397) that don't pre-strip parentheses.🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_js_analyze/src/lint/nursery/no_restricted_properties.rs` around lines 265 - 277, The call to omit_parentheses() in inspect_member_expression is redundant because identifier_object_name already calls omit_parentheses internally; remove the extra omit_parentheses() invocation so inspect_member_expression passes the raw object (the variable named object) into identifier_object_name(node.object().ok()?) and keep matching via match_restriction with identifier_object_name, property_name.text(), and property_name.range() unchanged.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/biome_js_analyze/src/lint/nursery/no_restricted_properties.rs`:
- Around line 265-277: The call to omit_parentheses() in
inspect_member_expression is redundant because identifier_object_name already
calls omit_parentheses internally; remove the extra omit_parentheses()
invocation so inspect_member_expression passes the raw object (the variable
named object) into identifier_object_name(node.object().ok()?) and keep matching
via match_restriction with identifier_object_name, property_name.text(), and
property_name.range() unchanged.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 93fccb9e-ea59-420f-aa1c-1840a0abe443
⛔ Files ignored due to path filters (12)
.opencode/package-lock.jsonis excluded by!**/package-lock.jsonand included by**Cargo.lockis excluded by!**/*.lockand included by**crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rsis excluded by!**/migrate/eslint_any_rule_to_biome.rsand included by**crates/biome_cli/tests/snapshots/main_commands_migrate_eslint/migrate_no_restricted_properties_with_options.snapis excluded by!**/*.snapand included by**crates/biome_configuration/src/analyzer/linter/rules.rsis excluded by!**/rules.rsand included by**crates/biome_configuration/src/generated/linter_options_check.rsis excluded by!**/generated/**,!**/generated/**and included by**crates/biome_diagnostics_categories/src/categories.rsis excluded by!**/categories.rsand included by**crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalid.js.snapis excluded by!**/*.snapand included by**crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalidConfig.js.snapis excluded by!**/*.snapand included by**crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/valid.js.snapis excluded by!**/*.snapand included by**packages/@biomejs/backend-jsonrpc/src/workspace.tsis excluded by!**/backend-jsonrpc/src/workspace.tsand included by**packages/@biomejs/biome/configuration_schema.jsonis excluded by!**/configuration_schema.jsonand included by**
📒 Files selected for processing (14)
.changeset/thick-coins-hide.mdcrates/biome_cli/src/execute/migrate/eslint_eslint.rscrates/biome_cli/src/execute/migrate/eslint_to_biome.rscrates/biome_cli/tests/commands/migrate_eslint.rscrates/biome_js_analyze/src/lint/nursery/no_restricted_properties.rscrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalid.jscrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalid.options.jsoncrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalidConfig.jscrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalidConfig.options.jsoncrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/valid.jscrates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/valid.options.jsoncrates/biome_rule_options/Cargo.tomlcrates/biome_rule_options/src/lib.rscrates/biome_rule_options/src/no_restricted_properties.rs
✅ Files skipped from review due to trivial changes (9)
- crates/biome_rule_options/src/lib.rs
- crates/biome_rule_options/Cargo.toml
- .changeset/thick-coins-hide.md
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/valid.js
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalidConfig.js
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalid.options.json
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalidConfig.options.json
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/valid.options.json
- crates/biome_js_analyze/tests/specs/nursery/noRestrictedProperties/invalid.js
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/biome_cli/src/execute/migrate/eslint_eslint.rs
ematipico
reviewed
Apr 17, 2026
ematipico
left a comment
Member
There was a problem hiding this comment.
Code looks fine, but docs need some rework
dyc3
force-pushed
the
dyc3/noRestrictedProperties
branch
from
April 17, 2026 20:28
2d32061 to
67e873c
Compare
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/biome_cli/tests/commands/migrate_eslint.rs (1)
407-458: Nice test — consider adding the severity-only sibling case.This covers populated entries well; a tiny
"error"-only case would also lock down theentries: Nonebranch.Suggested companion test
+#[test] +fn migrate_no_restricted_properties_no_options() { + let biomejson = r#"{}"#; + let eslintrc = r#"{ "rules": { "no-restricted-properties": "error" } }"#; + + let fs = MemoryFileSystem::default(); + fs.insert(Utf8Path::new("biome.json").into(), biomejson.as_bytes()); + fs.insert(Utf8Path::new(".eslintrc.json").into(), eslintrc.as_bytes()); + + let mut console = BufferConsole::default(); + let (fs, result) = run_cli( + fs, + &mut console, + Args::from( + ["migrate", "eslint", "--include-nursery", "--write"].as_slice(), + ), + ); + + assert!(result.is_ok(), "run_cli returned {result:?}"); + assert_cli_snapshot(SnapshotPayload::new( + module_path!(), + "migrate_no_restricted_properties_no_options", + fs, + console, + result, + )); +}🤖 Prompt for AI Agents
Verify each finding against the current code and only fix it if needed. In `@crates/biome_cli/tests/commands/migrate_eslint.rs` around lines 407 - 458, Add a companion test to cover the severity-only branch: create a new test (e.g., migrate_no_restricted_properties_severity_only) that supplies a .eslintrc.json where "no-restricted-properties" is just ["error"] (no entries object/array), mirror the same MemoryFileSystem, BufferConsole and run_cli invocation used in migrate_no_restricted_properties_with_options (Args::from with "migrate","eslint","--include-inspired","--include-nursery","--write"), assert run_cli is Ok and call assert_cli_snapshot with the new test name to lock down the entries: None branch.
🤖 Prompt for all review comments with AI agents
Verify each finding against the current code and only fix it if needed.
Nitpick comments:
In `@crates/biome_cli/tests/commands/migrate_eslint.rs`:
- Around line 407-458: Add a companion test to cover the severity-only branch:
create a new test (e.g., migrate_no_restricted_properties_severity_only) that
supplies a .eslintrc.json where "no-restricted-properties" is just ["error"] (no
entries object/array), mirror the same MemoryFileSystem, BufferConsole and
run_cli invocation used in migrate_no_restricted_properties_with_options
(Args::from with
"migrate","eslint","--include-inspired","--include-nursery","--write"), assert
run_cli is Ok and call assert_cli_snapshot with the new test name to lock down
the entries: None branch.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: 54eff383-6850-4d7d-8e9b-e3adae95b249
⛔ Files ignored due to path filters (5)
Cargo.lockis excluded by!**/*.lockand included by**crates/biome_cli/src/execute/migrate/eslint_any_rule_to_biome.rsis excluded by!**/migrate/eslint_any_rule_to_biome.rsand included by**crates/biome_cli/tests/snapshots/main_commands_migrate_eslint/migrate_no_restricted_properties_with_options.snapis excluded by!**/*.snapand included by**crates/biome_configuration/src/analyzer/linter/rules.rsis excluded by!**/rules.rsand included by**crates/biome_configuration/src/generated/linter_options_check.rsis excluded by!**/generated/**,!**/generated/**and included by**
📒 Files selected for processing (4)
.changeset/thick-coins-hide.mdcrates/biome_cli/src/execute/migrate/eslint_eslint.rscrates/biome_cli/src/execute/migrate/eslint_to_biome.rscrates/biome_cli/tests/commands/migrate_eslint.rs
✅ Files skipped from review due to trivial changes (1)
- .changeset/thick-coins-hide.md
🚧 Files skipped from review as they are similar to previous changes (1)
- crates/biome_cli/src/execute/migrate/eslint_eslint.rs
dyc3
force-pushed
the
dyc3/noRestrictedProperties
branch
from
April 17, 2026 20:37
67e873c to
8f36d38
Compare
Contributor
Author
|
Ok, I've rewritten the options docs by hand. I know that we usually put examples before options, but for this rule specifically: should we have the options first? I think it could make it flow better. We introduce the user to the options and how they work, then provide examples to demonstrate. |
ematipico
requested changes
Apr 18, 2026
Member
There was a problem hiding this comment.
I left some suggestions for the docs. As for rule, it's a rule specially tailored for JavaScript, and that's confirmed by the way the options are treated. Remember that options are shared across languages.
When rules are designed for a language or domain, they should carry their language in their name. For example useGraphqlNamingConvention. This rule should be named noJsRestrictedProperties. I don't see this rule being ported to other languages, because of the way identifiers are treated.
Comment on lines
+107
to
+111
| /// An array of restricted object/property combinations. Depending on the provided options, each entry can: | ||
| /// - Restrict a specific property on a specific object. | ||
| /// - Restrict all properties on a specific object except for an allowlist of properties. | ||
| /// - Restrict a specific property everywhere except for an allowlist of objects. | ||
| /// - Provide a custom message to include in the diagnostic when the restriction is violated. |
Member
There was a problem hiding this comment.
Suggested change
| /// An array of restricted object/property combinations. Depending on the provided options, each entry can: | |
| /// - Restrict a specific property on a specific object. | |
| /// - Restrict all properties on a specific object except for an allowlist of properties. | |
| /// - Restrict a specific property everywhere except for an allowlist of objects. | |
| /// - Provide a custom message to include in the diagnostic when the restriction is violated. | |
| /// An array of restricted object/property combinations. |
I removed the list because we're repeating the examples and the description of the properties below.
Comment on lines
+121
to
+127
| /// ### `entries[].allowObjects` | ||
| /// | ||
| /// When restricting a property, an optional allowlist of objects that are exempt from the restriction. Only applicable when `property` is provided and `object` is not provided. | ||
| /// | ||
| /// ### `entries[].allowProperties` | ||
| /// | ||
| /// When restricting an object, an optional allowlist of properties that are exempt from the restriction. Only applicable when `object` is provided and `property` is not provided. |
Member
There was a problem hiding this comment.
Here's a legitimate question that the docs should explain.
What if the configuration provides both? From what I read, the allow lists work only in certain conditions. If both property and object are provided, what happens?
Contributor
Author
There was a problem hiding this comment.
That's exactly what I was trying to address with the bullet points up here that you want removed: #9806 (comment)
Member
There was a problem hiding this comment.
Oh, I didn't understand that from the bullet list :(
Member
|
Friendly bump @dyc3 |
dyc3
force-pushed
the
dyc3/noRestrictedProperties
branch
from
July 23, 2026 15:14
8f36d38 to
da0e956
Compare
ematipico
approved these changes
Jul 23, 2026
Merged
OIRNOIR
pushed a commit
to OIRNOIR/YouTube-Helper-Server
that referenced
this pull request
Aug 4, 2026
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.5` -> `2.5.6`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.5/2.5.6) | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.6`](https://github.com/biomejs/biome/blob/HEAD/packages/@​biomejs/biome/CHANGELOG.md#256) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.5...@biomejs/biome@2.5.6) ##### Patch Changes - [#​11035](biomejs/biome#11035) [`0e4b03b`](biomejs/biome@0e4b03b) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a performance regression in [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) that caused type inference to run repeatedly while linting a file. - [#​11043](biomejs/biome#11043) [`22ec076`](biomejs/biome@22ec076) Thanks [@​denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatting for multiline function arguments preceded by comments: ```diff .example { value: outer( 1, /* comment */ nested( - first, - second - ) + first, + second + ) ); } ``` - [#​11007](biomejs/biome#11007) [`c9acb25`](biomejs/biome@c9acb25) Thanks [@​BTF-Kabir-2020](https://github.com/BTF-Kabir-2020)! - Fixed [#​9195](biomejs/biome#9195): [`useHookAtTopLevel`](https://biomejs.dev/linter/rules/use-hook-at-top-level/) no longer reports hooks in named `forwardRef` components that receive a `ref` parameter. - [#​10152](biomejs/biome#10152) [`50a9bd8`](biomejs/biome@50a9bd8) Thanks [@​Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed [#​10131](biomejs/biome#10131): Biome now correctly parses curried arrow functions in ternary consequents when the inner arrow's parameters use a destructuring pattern, e.g. `cond ? (x) => ({ a, b }) => body : alt`. - [#​11105](biomejs/biome#11105) [`8ffe2b9`](biomejs/biome@8ffe2b9) Thanks [@​dadavidtseng](https://github.com/dadavidtseng)! - Fixed [#​11092](biomejs/biome#11092): The [`noUselessTernary`](https://biomejs.dev/linter/rules/no-useless-ternary/) quick fix now preserves operator spacing when simplifying or inverting boolean ternary expressions. - [#​10533](biomejs/biome#10533) [`5809875`](biomejs/biome@5809875) Thanks [@​Mokto](https://github.com/Mokto)! - Fixed [#​10515](biomejs/biome#10515): `biome check --write` was not idempotent on Svelte files — multi-line template literals in `<script>` blocks and block comments in `<style>` blocks gained an extra indent level on every run. - [#​11040](biomejs/biome#11040) [`0abb620`](biomejs/biome@0abb620) Thanks [@​Mokto](https://github.com/Mokto)! - Fixed an issue where the HTML formatter would duplicate a comment placed directly before a Svelte `{@​const ...}` or `{@​debug ...}` block. The duplication compounded on every subsequent `--write`, causing the file to grow exponentially. - [#​10858](biomejs/biome#10858) [`6d18204`](biomejs/biome@6d18204) Thanks [@​ruidosujeira](https://github.com/ruidosujeira)! - Fixed [#​10839](biomejs/biome#10839): Svelte `{#each}` array destructuring no longer includes spaces inside square brackets, and multiline bind function expressions now indent their getter, setter, and function body correctly. - [#​11009](biomejs/biome#11009) [`2c36626`](biomejs/biome@2c36626) Thanks [@​ematipico](https://github.com/ematipico)! - Improved the accuracy of type-aware lint rules by resolving more inferred types. For example, [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) now detects floating Promises returned by aliased callbacks and arrays of Promises created by async mapping callbacks. The following statements are now reported: ```ts type AsyncCallback = () => Promise<void>; declare const callback: AsyncCallback; callback(); [1, 2, 3].map(async (value) => value); ``` - [#​10973](biomejs/biome#10973) [`9cb044c`](biomejs/biome@9cb044c) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed false positives in [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) when generic-constraint, normalization, substitution, or structural return-type comparison cannot complete. The rule now suppresses diagnostics rather than suggesting a return type derived from partial information. For example, this unresolved return type is no longer reported: ```ts function unresolvedReturnType(): MissingType { return "value" as const; } ``` - [#​11071](biomejs/biome#11071) [`15047a2`](biomejs/biome@15047a2) Thanks [@​dyc3](https://github.com/dyc3)! - The HTML parser now accepts mixed-case `doctype` declarations. - [#​11030](biomejs/biome#11030) [`cc90e65`](biomejs/biome@cc90e65) Thanks [@​marschattha](https://github.com/marschattha)! - The `rdjson` reporter now populates the [severity](https://github.com/reviewdog/reviewdog/blob/master/proto/rdf/reviewdog.proto) field of each diagnostic (`ERROR`, `WARNING`, or `INFO`), so tools consuming Reviewdog Diagnostic Format output no longer need to assume a default severity. - [#​11009](biomejs/biome#11009) [`2c36626`](biomejs/biome@2c36626) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a performance regression in type-aware JavaScript lint rules by inferring only requested types and memoizing export resolution. - [#​11056](biomejs/biome#11056) [`903b177`](biomejs/biome@903b177) Thanks [@​dyc3](https://github.com/dyc3)! - Added support for Svelte declaration tags using `let` and `const`. Biome can now parse, format, and lint bindings declared in these tags. - [#​11045](biomejs/biome#11045) [`89c27c6`](biomejs/biome@89c27c6) Thanks [@​ematipico](https://github.com/ematipico)! - Improved the performance of Biome formatter up to \~7% across the board. - [#​9806](biomejs/biome#9806) [`781d68d`](biomejs/biome@781d68d) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noJsRestrictedProperties`](https://biomejs.dev/linter/rules/no-js-restricted-properties/), which ports ESLint's `no-restricted-properties` rule. Biome now flags restricted member access and object destructuring, and `biome migrate eslint` preserves the rule's options. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODQuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI4NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/33
OIRNOIR
pushed a commit
to OIRNOIR/YouTube-Helper-Client
that referenced
this pull request
Aug 4, 2026
This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.5` -> `2.5.6`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.5/2.5.6) | `2.5.7` | --- ### Release Notes <details> <summary>biomejs/biome (@​biomejs/biome)</summary> ### [`v2.5.6`](https://github.com/biomejs/biome/blob/HEAD/packages/@​biomejs/biome/CHANGELOG.md#256) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.5...@biomejs/biome@2.5.6) ##### Patch Changes - [#​11035](biomejs/biome#11035) [`0e4b03b`](biomejs/biome@0e4b03b) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a performance regression in [`noMisusedPromises`](https://biomejs.dev/linter/rules/no-misused-promises/) that caused type inference to run repeatedly while linting a file. - [#​11043](biomejs/biome#11043) [`22ec076`](biomejs/biome@22ec076) Thanks [@​denbezrukov](https://github.com/denbezrukov)! - Fixed CSS formatting for multiline function arguments preceded by comments: ```diff .example { value: outer( 1, /* comment */ nested( - first, - second - ) + first, + second + ) ); } ``` - [#​11007](biomejs/biome#11007) [`c9acb25`](biomejs/biome@c9acb25) Thanks [@​BTF-Kabir-2020](https://github.com/BTF-Kabir-2020)! - Fixed [#​9195](biomejs/biome#9195): [`useHookAtTopLevel`](https://biomejs.dev/linter/rules/use-hook-at-top-level/) no longer reports hooks in named `forwardRef` components that receive a `ref` parameter. - [#​10152](biomejs/biome#10152) [`50a9bd8`](biomejs/biome@50a9bd8) Thanks [@​Zelys-DFKH](https://github.com/Zelys-DFKH)! - Fixed [#​10131](biomejs/biome#10131): Biome now correctly parses curried arrow functions in ternary consequents when the inner arrow's parameters use a destructuring pattern, e.g. `cond ? (x) => ({ a, b }) => body : alt`. - [#​11105](biomejs/biome#11105) [`8ffe2b9`](biomejs/biome@8ffe2b9) Thanks [@​dadavidtseng](https://github.com/dadavidtseng)! - Fixed [#​11092](biomejs/biome#11092): The [`noUselessTernary`](https://biomejs.dev/linter/rules/no-useless-ternary/) quick fix now preserves operator spacing when simplifying or inverting boolean ternary expressions. - [#​10533](biomejs/biome#10533) [`5809875`](biomejs/biome@5809875) Thanks [@​Mokto](https://github.com/Mokto)! - Fixed [#​10515](biomejs/biome#10515): `biome check --write` was not idempotent on Svelte files — multi-line template literals in `<script>` blocks and block comments in `<style>` blocks gained an extra indent level on every run. - [#​11040](biomejs/biome#11040) [`0abb620`](biomejs/biome@0abb620) Thanks [@​Mokto](https://github.com/Mokto)! - Fixed an issue where the HTML formatter would duplicate a comment placed directly before a Svelte `{@​const ...}` or `{@​debug ...}` block. The duplication compounded on every subsequent `--write`, causing the file to grow exponentially. - [#​10858](biomejs/biome#10858) [`6d18204`](biomejs/biome@6d18204) Thanks [@​ruidosujeira](https://github.com/ruidosujeira)! - Fixed [#​10839](biomejs/biome#10839): Svelte `{#each}` array destructuring no longer includes spaces inside square brackets, and multiline bind function expressions now indent their getter, setter, and function body correctly. - [#​11009](biomejs/biome#11009) [`2c36626`](biomejs/biome@2c36626) Thanks [@​ematipico](https://github.com/ematipico)! - Improved the accuracy of type-aware lint rules by resolving more inferred types. For example, [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) now detects floating Promises returned by aliased callbacks and arrays of Promises created by async mapping callbacks. The following statements are now reported: ```ts type AsyncCallback = () => Promise<void>; declare const callback: AsyncCallback; callback(); [1, 2, 3].map(async (value) => value); ``` - [#​10973](biomejs/biome#10973) [`9cb044c`](biomejs/biome@9cb044c) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed false positives in [`noMisleadingReturnType`](https://biomejs.dev/linter/rules/no-misleading-return-type/) when generic-constraint, normalization, substitution, or structural return-type comparison cannot complete. The rule now suppresses diagnostics rather than suggesting a return type derived from partial information. For example, this unresolved return type is no longer reported: ```ts function unresolvedReturnType(): MissingType { return "value" as const; } ``` - [#​11071](biomejs/biome#11071) [`15047a2`](biomejs/biome@15047a2) Thanks [@​dyc3](https://github.com/dyc3)! - The HTML parser now accepts mixed-case `doctype` declarations. - [#​11030](biomejs/biome#11030) [`cc90e65`](biomejs/biome@cc90e65) Thanks [@​marschattha](https://github.com/marschattha)! - The `rdjson` reporter now populates the [severity](https://github.com/reviewdog/reviewdog/blob/master/proto/rdf/reviewdog.proto) field of each diagnostic (`ERROR`, `WARNING`, or `INFO`), so tools consuming Reviewdog Diagnostic Format output no longer need to assume a default severity. - [#​11009](biomejs/biome#11009) [`2c36626`](biomejs/biome@2c36626) Thanks [@​ematipico](https://github.com/ematipico)! - Fixed a performance regression in type-aware JavaScript lint rules by inferring only requested types and memoizing export resolution. - [#​11056](biomejs/biome#11056) [`903b177`](biomejs/biome@903b177) Thanks [@​dyc3](https://github.com/dyc3)! - Added support for Svelte declaration tags using `let` and `const`. Biome can now parse, format, and lint bindings declared in these tags. - [#​11045](biomejs/biome#11045) [`89c27c6`](biomejs/biome@89c27c6) Thanks [@​ematipico](https://github.com/ematipico)! - Improved the performance of Biome formatter up to \~7% across the board. - [#​9806](biomejs/biome#9806) [`781d68d`](biomejs/biome@781d68d) Thanks [@​dyc3](https://github.com/dyc3)! - Added the nursery rule [`noJsRestrictedProperties`](https://biomejs.dev/linter/rules/no-js-restricted-properties/), which ports ESLint's `no-restricted-properties` rule. Biome now flags restricted member access and object destructuring, and `biome migrate eslint` preserves the rule's options. </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://github.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiI0My4yODQuMCIsInVwZGF0ZWRJblZlciI6IjQzLjI4NC4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiIsImxhYmVscyI6W119--> Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds
noRestrictedPropertieswhich is a port of https://eslint.org/docs/latest/rules/no-restricted-propertiesThe main reason to add this rule is that it will be a faster alternative than users writing grit plugins for similar use cases.
generated by gpt 5.4, heavily steered to get it to stop allocating strings
Test Plan
snapshots
Docs