refactor(tests): reorganize SCSS test specs into standalone `scss` module by denbezrukov · Pull Request #10030 · biomejs/biome

denbezrukov · 2026-04-18T06:43:41Z

Summary

Move scss tests outside from a css directory.

Test Plan

Green CI

…dule

changeset-bot · 2026-04-18T06:43:46Z

⚠️ No Changeset found

Latest commit: fa78600

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

coderabbitai · 2026-04-18T06:47:22Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: ae687150-c1cb-4e8d-841f-2fa84d33c986

📥 Commits

Reviewing files that changed from the base of the PR and between e3fb00b and fa78600.

⛔ Files ignored due to path filters (49)

crates/biome_css_formatter/tests/specs/scss/at-rule/at-root.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/container-general-enclosed.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/container-scroll-state.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/content.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/debug-warn-error.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/declaration-block-interpolation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/each.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/else.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/extend.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/for.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/forward.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/function.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/if-else.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/import.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/include.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/media-interpolation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/mixin.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/return.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/supports-expression.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/supports-general-enclosed.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/use.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/at-rule/while.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/ambiguous-selector-vs-nesting.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/bracketed-values.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/global-flag.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/interpolation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/mixed.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/namespaced.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-complex-value.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-empty-value.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-with-value.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/page-at-rule.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/parent-and-colon-values.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/quote_style/interpolated-string.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/simple-variable.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/spacing-after-colon.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/string-interpolation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/unquoted-concatenation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/declaration/url-interpolated-functions.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/bracketed-values.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/edge-cases.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/formatting.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/function-call.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/interpolation.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/list-map-paren.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/precedence.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/qualified-names.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/expression/signed-numeric-operator.scss.snap is excluded by !**/*.snap and included by **
crates/biome_css_formatter/tests/specs/scss/selector/interpolation.scss.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (51)

crates/biome_css_formatter/tests/spec_tests.rs
crates/biome_css_formatter/tests/specs/scss/at-rule/at-root.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/container-general-enclosed.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/container-scroll-state.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/content.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/debug-warn-error.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/declaration-block-interpolation.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/each.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/else.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/extend.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/for.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/forward.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/function.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/if-else.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/import.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/include.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/media-interpolation.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/mixin.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/return.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/supports-expression.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/supports-general-enclosed.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/use.scss
crates/biome_css_formatter/tests/specs/scss/at-rule/while.scss
crates/biome_css_formatter/tests/specs/scss/declaration/ambiguous-selector-vs-nesting.scss
crates/biome_css_formatter/tests/specs/scss/declaration/bracketed-values.scss
crates/biome_css_formatter/tests/specs/scss/declaration/global-flag.scss
crates/biome_css_formatter/tests/specs/scss/declaration/interpolation.scss
crates/biome_css_formatter/tests/specs/scss/declaration/mixed.scss
crates/biome_css_formatter/tests/specs/scss/declaration/namespaced.scss
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-complex-value.scss
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-empty-value.scss
crates/biome_css_formatter/tests/specs/scss/declaration/nested-properties-with-value.scss
crates/biome_css_formatter/tests/specs/scss/declaration/page-at-rule.scss
crates/biome_css_formatter/tests/specs/scss/declaration/parent-and-colon-values.scss
crates/biome_css_formatter/tests/specs/scss/declaration/quote_style/interpolated-string.scss
crates/biome_css_formatter/tests/specs/scss/declaration/quote_style/options.json
crates/biome_css_formatter/tests/specs/scss/declaration/simple-variable.scss
crates/biome_css_formatter/tests/specs/scss/declaration/spacing-after-colon.scss
crates/biome_css_formatter/tests/specs/scss/declaration/string-interpolation.scss
crates/biome_css_formatter/tests/specs/scss/declaration/unquoted-concatenation.scss
crates/biome_css_formatter/tests/specs/scss/declaration/url-interpolated-functions.scss
crates/biome_css_formatter/tests/specs/scss/expression/bracketed-values.scss
crates/biome_css_formatter/tests/specs/scss/expression/edge-cases.scss
crates/biome_css_formatter/tests/specs/scss/expression/formatting.scss
crates/biome_css_formatter/tests/specs/scss/expression/function-call.scss
crates/biome_css_formatter/tests/specs/scss/expression/interpolation.scss
crates/biome_css_formatter/tests/specs/scss/expression/list-map-paren.scss
crates/biome_css_formatter/tests/specs/scss/expression/precedence.scss
crates/biome_css_formatter/tests/specs/scss/expression/qualified-names.scss
crates/biome_css_formatter/tests/specs/scss/expression/signed-numeric-operator.scss
crates/biome_css_formatter/tests/specs/scss/selector/interpolation.scss

Walkthrough

The test generation for CSS and SCSS specification files has been reorganised. Previously, a single test generation invocation covered both .css and .scss files via a combined glob pattern. This has been split into two distinct modules, with one generating tests specifically for CSS files and another for SCSS files, using separate glob patterns to isolate each file type.

🚥 Pre-merge checks | ✅ 2

✅ Passed checks (2 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: reorganising SCSS test specs into a standalone module, which aligns with the changeset's purpose of separating SCSS tests from the CSS directory.
Description check	✅ Passed	The description is directly related to the changeset, explaining that SCSS tests are being moved out of the CSS directory, which matches the actual changes shown in the summary.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch db/prettier-formatter-2

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

codspeed · 2026-04-18T06:53:20Z

Merging this PR will not alter performance

✅ 29 untouched benchmarks
⏩ 227 skipped benchmarks¹

_{Comparing db/prettier-formatter-2 (fa78600) with main (e3fb00b)}

227 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

refactor(tests): reorganize SCSS test specs into standalone scss mo…

fa78600

…dule

github-actions Bot added A-Formatter Area: formatter L-CSS Language: CSS and super languages labels Apr 18, 2026

denbezrukov merged commit 8b3f6f1 into main Apr 18, 2026
28 checks passed

denbezrukov deleted the db/prettier-formatter-2 branch April 18, 2026 07:17

coderabbitai Bot mentioned this pull request Apr 21, 2026

feat(css_formatter): improve SCSS map formatting parity #10076

Merged

Navigation Menu

Uh oh!

refactor(tests): reorganize SCSS test specs into standalone `scss` module - #10030

refactor(tests): reorganize SCSS test specs into standalone `scss` module#10030
denbezrukov merged 1 commit into
mainfrom
db/prettier-formatter-2

denbezrukov commented Apr 18, 2026

Uh oh!

changeset-bot Bot commented Apr 18, 2026

Uh oh!

coderabbitai Bot commented Apr 18, 2026

Uh oh!

codspeed Bot commented Apr 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

denbezrukov commented Apr 18, 2026

Summary

Test Plan

Uh oh!

changeset-bot Bot commented Apr 18, 2026

⚠️ No Changeset found

Uh oh!

coderabbitai Bot commented Apr 18, 2026

Walkthrough

Uh oh!

codspeed Bot commented Apr 18, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant