Skip to content

test(css_formatter): sync Prettier CSS and SCSS fixtures - #10554

Merged
denbezrukov merged 1 commit into
mainfrom
db/scss-update-test
Jun 4, 2026
Merged

test(css_formatter): sync Prettier CSS and SCSS fixtures#10554
denbezrukov merged 1 commit into
mainfrom
db/scss-update-test

Conversation

@denbezrukov

@denbezrukov denbezrukov commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Summary

Syncs CSS and SCSS Prettier compatibility fixtures

Test Plan

cargo test -p biome_css_formatter

@changeset-bot

changeset-bot Bot commented Jun 3, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 096bd39

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

✅ Organic activity

No automation signals detected in the analyzed events.

View full analysis →

This is an automated analysis by AgentScan

@github-actions github-actions Bot added A-Formatter Area: formatter L-CSS Language: CSS and super languages labels Jun 3, 2026
@coderabbitai

coderabbitai Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro

Run ID: 702bf163-e923-4f64-82c2-790f04b08a35

📥 Commits

Reviewing files that changed from the base of the PR and between 0f29b83 and 096bd39.

⛔ Files ignored due to path filters (7)
  • crates/biome_css_formatter/tests/specs/prettier/css/custom-properties/emoji.css.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/css/escaped-attribute/test.css.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/scss/function/18465.scss.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/3235.scss.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/comment.scss.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/key-values.scss.snap is excluded by !**/*.snap and included by **
  • crates/biome_css_formatter/tests/specs/prettier/scss/math/7419.scss.snap is excluded by !**/*.snap and included by **
📒 Files selected for processing (9)
  • crates/biome_css_formatter/tests/specs/prettier/css/custom-properties/emoji.css.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/css/escaped-attribute/test.css.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/function/18465.scss.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/function/issue-19073.scss
  • crates/biome_css_formatter/tests/specs/prettier/scss/function/issue-19073.scss.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/3235.scss.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/comment.scss.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/map/key-values.scss.prettier-snap
  • crates/biome_css_formatter/tests/specs/prettier/scss/math/7419.scss.prettier-snap

Walkthrough

This pull request updates Prettier formatter snapshot files for CSS and SCSS to reflect formatting adjustments. Changes include corrected line breaking in CSS custom-properties and escaped-attribute selectors, simplified SCSS function expressions, adjusted value layout in SCSS maps (shifting between multi-line and single-line forms), and condensed @include argument formatting. A new SCSS test case for rgba() with named arguments is added alongside its snapshot.

Possibly related PRs

  • biomejs/biome#10217: SCSS map/list value expansion logic changes that affect parenthesised value rendering in maps.
  • biomejs/biome#10076: SCSS map formatter refactoring and trailing-comment handling logic changes.
  • biomejs/biome#10147: SCSS @include argument list and parameter formatting logic updates.

Suggested labels

A-Formatter, L-CSS

Suggested reviewers

  • ematipico
  • dyc3
🚥 Pre-merge checks | ✅ 4
✅ Passed checks (4 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and specifically describes the main change—syncing Prettier CSS and SCSS test fixtures.
Description check ✅ Passed The description directly relates to the changeset, explaining what is being synced and providing a test plan.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch db/scss-update-test

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

dyc3
dyc3 approved these changes Jun 3, 2026
View reviewed changes
Comment thread crates/biome_css_formatter/tests/specs/prettier/css/custom-properties/emoji.css.prettier-snap
color: red; {
color: red;
/* 😄😄😄😄😄😄😄😄😄😄😄
/* 😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄😄 */

@dyc3 dyc3 Jun 3, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😄

@denbezrukov
denbezrukov merged commit 232a5cb into main Jun 4, 2026
28 checks passed
@denbezrukov
denbezrukov deleted the db/scss-update-test branch June 4, 2026 05:47
THernandez03 pushed a commit to THernandez03/biome that referenced this pull request Jun 22, 2026
@denbezrukov @THernandez03
test(css_formatter): sync Prettier CSS and SCSS fixtures (biomejs#10554)
d6a4fe4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dyc3 dyc3 dyc3 approved these changes

Assignees

No one assigned

Labels

A-Formatter Area: formatter L-CSS Language: CSS and super languages

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@denbezrukov @dyc3