Conversation
|
Contributor
✅ Organic activityNo automation signals detected in the analyzed events. This is an automated analysis by AgentScan |
siketyan
marked this pull request as ready for review
July 14, 2026 16:34
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
WalkthroughThe pull request replaces the nightly Possibly related PRs
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
ematipico
reviewed
Jul 14, 2026
Merging this PR will not alter performance
Comparing Footnotes
|
siketyan
marked this pull request as draft
July 14, 2026 16:48
Contributor
Parser conformance results onjs/262
jsx/babel
markdown/commonmark
symbols/microsoft
ts/babel
ts/microsoft
|
# Conflicts: # crates/biome_html_analyze/Cargo.toml
Contributor
There was a problem hiding this comment.
🧹 Nitpick comments (1)
crates/biome_css_parser/Cargo.toml (1)
32-32: 📐 Maintainability & Code Quality | 🔵 Trivial | ⚡ Quick winUse local paths for internal dev-dependencies.
crates/biome_css_parser/Cargo.toml#L32-L32: changebiome_diagnosticstopath = "../biome_diagnostics".crates/biome_graphql_analyze/Cargo.toml#L31-L31: changebiome_languagestopath = "../biome_languages".crates/biome_graphql_formatter/Cargo.toml#L36-L36: changebiome_languagestopath = "../biome_languages".As per coding guidelines, internal
biome_*crates in[dev-dependencies]must usepathdependencies rather thanworkspace = true.🤖 Prompt for AI Agents
Verify each finding against current code. Fix only still-valid issues, skip the rest with a brief reason, keep changes minimal, and validate. In `@crates/biome_css_parser/Cargo.toml` at line 32, Replace the workspace-based internal dev-dependencies with local path dependencies: use path "../biome_diagnostics" for biome_diagnostics in crates/biome_css_parser/Cargo.toml:32-32, and path "../biome_languages" for biome_languages in crates/biome_graphql_analyze/Cargo.toml:31-31 and crates/biome_graphql_formatter/Cargo.toml:36-36.Source: Coding guidelines
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Nitpick comments:
In `@crates/biome_css_parser/Cargo.toml`:
- Line 32: Replace the workspace-based internal dev-dependencies with local path
dependencies: use path "../biome_diagnostics" for biome_diagnostics in
crates/biome_css_parser/Cargo.toml:32-32, and path "../biome_languages" for
biome_languages in crates/biome_graphql_analyze/Cargo.toml:31-31 and
crates/biome_graphql_formatter/Cargo.toml:36-36.
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro
Run ID: f6ca858c-a4ff-4d57-9966-5c72326fe7c4
⛔ Files ignored due to path filters (1)
Cargo.lockis excluded by!**/*.lockand included by**
📒 Files selected for processing (64)
.github/workflows/pull_request.ymlCargo.tomlcrates/biome_analyze/Cargo.tomlcrates/biome_cli/Cargo.tomlcrates/biome_configuration/Cargo.tomlcrates/biome_configuration/src/organize_imports.rscrates/biome_css_analyze/Cargo.tomlcrates/biome_css_formatter/Cargo.tomlcrates/biome_css_parser/Cargo.tomlcrates/biome_css_parser/src/lib.rscrates/biome_css_parser/src/prelude.rscrates/biome_css_syntax/Cargo.tomlcrates/biome_formatter/Cargo.tomlcrates/biome_formatter_test/Cargo.tomlcrates/biome_fs/Cargo.tomlcrates/biome_graphql_analyze/Cargo.tomlcrates/biome_graphql_formatter/Cargo.tomlcrates/biome_graphql_parser/Cargo.tomlcrates/biome_grit_formatter/Cargo.tomlcrates/biome_grit_parser/Cargo.tomlcrates/biome_grit_patterns/src/parse.rscrates/biome_html_analyze/Cargo.tomlcrates/biome_html_formatter/Cargo.tomlcrates/biome_html_formatter/src/astro/auxiliary/expression.rscrates/biome_html_parser/Cargo.tomlcrates/biome_html_syntax/Cargo.tomlcrates/biome_html_syntax/src/generated.rscrates/biome_js_analyze/Cargo.tomlcrates/biome_js_formatter/Cargo.tomlcrates/biome_js_formatter/src/format.rscrates/biome_js_parser/Cargo.tomlcrates/biome_js_semantic/src/semantic_model.rscrates/biome_js_syntax/Cargo.tomlcrates/biome_js_type_info/Cargo.tomlcrates/biome_json_formatter/Cargo.tomlcrates/biome_json_parser/Cargo.tomlcrates/biome_json_syntax/Cargo.tomlcrates/biome_lsp/Cargo.tomlcrates/biome_lsp_converters/Cargo.tomlcrates/biome_markdown_formatter/Cargo.tomlcrates/biome_markdown_parser/Cargo.tomlcrates/biome_markdown_syntax/Cargo.tomlcrates/biome_markdown_syntax/src/generated.rscrates/biome_migrate/Cargo.tomlcrates/biome_module_graph/Cargo.tomlcrates/biome_project_layout/Cargo.tomlcrates/biome_resolver/Cargo.tomlcrates/biome_rowan/Cargo.tomlcrates/biome_rule_options/src/use_single_case_statement.rscrates/biome_service/Cargo.tomlcrates/biome_service/src/workspace/document/mod.rscrates/biome_service/src/workspace/document/services/mod.rscrates/biome_tailwind_parser/Cargo.tomlcrates/biome_tailwind_syntax/Cargo.tomlcrates/biome_tailwind_syntax/src/generated.rscrates/biome_test_utils/Cargo.tomlcrates/biome_wasm/Cargo.tomlcrates/biome_yaml_formatter/Cargo.tomlcrates/biome_yaml_parser/Cargo.tomlcrates/biome_yaml_syntax/Cargo.tomlcrates/biome_yaml_syntax/src/generated.rsxtask/codegen/Cargo.tomlxtask/coverage/Cargo.tomlxtask/rules_check/Cargo.toml
💤 Files with no reviewable changes (26)
- crates/biome_lsp_converters/Cargo.toml
- crates/biome_css_parser/src/prelude.rs
- crates/biome_grit_formatter/Cargo.toml
- crates/biome_module_graph/Cargo.toml
- crates/biome_service/src/workspace/document/services/mod.rs
- crates/biome_grit_patterns/src/parse.rs
- crates/biome_js_type_info/Cargo.toml
- crates/biome_js_parser/Cargo.toml
- crates/biome_css_parser/src/lib.rs
- crates/biome_fs/Cargo.toml
- crates/biome_wasm/Cargo.toml
- crates/biome_rule_options/src/use_single_case_statement.rs
- crates/biome_project_layout/Cargo.toml
- crates/biome_service/src/workspace/document/mod.rs
- crates/biome_configuration/src/organize_imports.rs
- crates/biome_html_formatter/src/astro/auxiliary/expression.rs
- xtask/rules_check/Cargo.toml
- crates/biome_lsp/Cargo.toml
- crates/biome_js_formatter/src/format.rs
- crates/biome_formatter/Cargo.toml
- crates/biome_cli/Cargo.toml
- crates/biome_resolver/Cargo.toml
- xtask/codegen/Cargo.toml
- crates/biome_css_formatter/Cargo.toml
- crates/biome_html_formatter/Cargo.toml
- crates/biome_test_utils/Cargo.toml
ematipico
approved these changes
Jul 15, 2026
ematipico
left a comment
Member
There was a problem hiding this comment.
Found an incorrect change. Merge away once it's resolved
This was referenced Jul 31, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes use of cargo-udeps and use cargo-shear instead.
cargo-shear doesn't expand macros by default, so there are some false positives; usages in macros are not considered. If we choose to use macro expansion, it needs the nightly toolchain.
Test Plan
CI should be green
Docs
N/A