fix(noDuplicateProperties): handle function named by ematipico · Pull Request #11591 · biomejs/biome

ematipico · 2026-09-02T09:26:20Z

Summary

Implemented via a coding agent.

The rule now needs the semantic model to correctly infer the rules that it can query.

I also did some cleanup with the APIs. It was a recent refactor, but the root nodes were left there. They weren't used, so now we can remove them.

Test Plan

Added new tests

Docs

changeset-bot · 2026-09-02T09:26:28Z

🦋 Changeset detected

Latest commit: 08cebc2

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages

Name	Type
@biomejs/biome	Patch
@biomejs/cli-darwin-arm64	Patch
@biomejs/cli-darwin-x64	Patch
@biomejs/cli-linux-arm64-musl	Patch
@biomejs/cli-linux-arm64	Patch
@biomejs/cli-linux-x64-musl	Patch
@biomejs/cli-linux-x64	Patch
@biomejs/cli-win32-arm64	Patch
@biomejs/cli-win32-x64	Patch
@biomejs/wasm-bundler	Patch
@biomejs/wasm-nodejs	Patch
@biomejs/wasm-web	Patch
@biomejs/backend-jsonrpc	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

coderabbitai · 2026-09-02T09:33:37Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Essentials

Run ID: 1046d448-567f-4cba-8483-b782c0da704b

📥 Commits

Reviewing files that changed from the base of the PR and between b6611dd and 08cebc2.

⛔ Files ignored due to path filters (2)

crates/biome_css_analyze/tests/specs/suspicious/noDuplicateProperties/invalid_6615.css.snap is excluded by !**/*.snap and included by **
crates/biome_css_analyze/tests/specs/suspicious/noDuplicateProperties/valid_6615.css.snap is excluded by !**/*.snap and included by **

📒 Files selected for processing (11)

.changeset/fix-no-duplicate-properties-nested-at-rules.md
crates/biome_css_analyze/src/lint/correctness/no_missing_var_function.rs
crates/biome_css_analyze/src/lint/style/no_descending_specificity.rs
crates/biome_css_analyze/src/lint/suspicious/no_duplicate_custom_properties.rs
crates/biome_css_analyze/src/lint/suspicious/no_duplicate_properties.rs
crates/biome_css_analyze/tests/specs/suspicious/noDuplicateProperties/invalid_6615.css
crates/biome_css_analyze/tests/specs/suspicious/noDuplicateProperties/valid_6615.css
crates/biome_css_semantic/src/format_semantic_model.rs
crates/biome_css_semantic/src/semantic_model/db.rs
crates/biome_css_semantic/src/semantic_model/model.rs
crates/biome_service/src/file_handlers/css/go_to.rs

Included review availability: Your plan provides up to 10 included reviews per hour; 7 remain after this review.

Walkthrough

The semantic model removes unused explicit CSS root parameters from selector and declaration accessors. Formatting, navigation, database, and lint consumers use the updated APIs. noDuplicateProperties now checks declarations directly belonging to the queried block and ignores nested mixin declarations. New valid and invalid fixtures cover this behaviour. A patch changeset documents the fix.

Merge Risk: ⚪ Minimal · up to 08ceb

This localized CSS lint and semantic-model change includes targeted tests and no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4

✅ Passed checks (4 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title identifies the affected rule and the function-named construct issue. However, the wording is incomplete and does not clearly state that the change fixes a false positive.
Description check	✅ Passed	The description explains the noDuplicateProperties false positive, links issue `#6615`, describes the semantic model changes, and mentions added tests.
Linked Issues check	✅ Passed	The changes satisfy issue `#6615` by limiting duplicate-property checks to declarations in the current block rather than nested blocks. The added fixtures cover the nested mixin case. The removed root p…
Out of Scope Changes check	✅ Passed	The changeset, rule updates, semantic API cleanup, service update, and test fixtures all support the reported noDuplicateProperties fix. No unrelated code changes are evident.

Full details: Linked Issues check

Explanation

The changes satisfy issue #6615 by limiting duplicate-property checks to declarations in the current block rather than nested blocks. The added fixtures cover the nested mixin case. The removed root parameters support this implementation and do not conflict with the issue objectives.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch fix/no-duplicate-properties

_{Comment @coderabbitai help to get the list of available commands.}

codspeed · 2026-09-02T09:41:21Z

Merging this PR will not alter performance

✅ 50 untouched benchmarks
⏩ 271 skipped benchmarks¹

_{Comparing fix/no-duplicate-properties (08cebc2) with main (b6611dd)}

271 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports. ↩

This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.11` -> `2.5.12`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.11/2.5.12) | `2.5.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.12`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2512) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.11...@biomejs/biome@2.5.12) ##### Patch Changes - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed Astro attribute expressions rejecting TypeScript and JSX syntax that is accepted in text expressions. ```astro <Component icon={<Icon />} count={total as number} onSelect={(e: Event) => e} /> ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed Astro attribute names being split on `:` and `.` inside an expression, such as `{x && <button x-on:keyup.enter={go} client:load.foo />}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a bare `>` in the children of an Astro expression being treated as markup, such as `{x && <div>a > b</div>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed HTML comments inside an Astro expression failing to parse. They are now read as trivia, wherever they appear among the children. ```astro {x && <div>text</div>} {cond && <a></a><b></b>} ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed `is:raw` children inside an Astro expression being read as JSX, such as `{x && <div is:raw>{not js} < & text</div>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed an apostrophe or quote in the text of a JSX element inside an Astro expression ending the expression early, such as `{items.map((i) => <li>it's {i}</li>)}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed the children of a `<script>` or `<style>` inside an Astro expression being read as JSX. Their contents are text, so braces and comparisons no longer have to be escaped. ```astro {cond && <style>a { color: red }</style>} {cond && <script>let x = {a: 1};</script>} ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Added support for template literal attribute values inside an Astro expression, such as ``{x && <C data-x=`t${x}` />}``. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed unquoted attribute values being rejected inside an Astro expression, such as `{x && <a class=foo maxlength=255 href=/about>go</a>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a template literal nested inside `${}` breaking the rest of an Astro file, such as ``const href = `/blog${page === 0 ? '' : `/${page + 1}`}`;``. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a quote inside a regex character class breaking the rest of an Astro file, such as `const unsafe = /[/"]/;`. - [#11508](biomejs/biome#11508) [`54f3a2e`](biomejs/biome@54f3a2e) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useFlatMathMinMax`](https://biomejs.dev/linter/rules/use-flat-math-min-max/). Because `Math.min()` and `Math.max()` accept any number of arguments, the rule reports unnecessary nested calls to the same method: ```js Math.max(Math.max(a, b), c); ``` The fix flattens this expression to `Math.max(a, b, c)`. - [#11585](biomejs/biome#11585) [`c5c8315`](biomejs/biome@c5c8315) Thanks [@Netail](https://github.com/Netail)! - Fixed [#11475](biomejs/biome#11475): `noUnresolvedImports` no longer reports Bun runtime built-in modules (`bun`, `bun:bundle`, `bun:ffi`, `bun:jsc`, `bun:sqlite`, `bun:test`). - [#11368](biomejs/biome#11368) [`52a57b3`](biomejs/biome@52a57b3) Thanks [@Austin1serb](https://github.com/Austin1serb)! - Fixed [#6830](biomejs/biome#6830): Biome now reports a diagnostic for excessively deep syntax instead of overflowing the native stack while releasing the parsed tree. - [#11596](biomejs/biome#11596) [`1fc42ed`](biomejs/biome@1fc42ed) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noThisOutsideOfClass`](https://biomejs.dev/linter/rules/no-this-outside-of-class/). The rule reports `this` outside class members and TypeScript functions with an explicit `this` parameter. ```js function Person(name) { this.name = name; } ``` - [#11555](biomejs/biome#11555) [`2516335`](biomejs/biome@2516335) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11529](biomejs/biome#11529), where [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) missed unhandled Promise chains when the imported function's module belonged to an import cycle. Cyclic modules now preserve types for exports that do not participate in recursive type dependencies. - [#11518](biomejs/biome#11518) [`0fee70c`](biomejs/biome@0fee70c) Thanks [@HarperZ9](https://github.com/HarperZ9)! - Fixed [#11500](biomejs/biome#11500): the formatter now prints the `declare` modifier before accessibility modifiers on class properties. `private declare readonly name: string` is now formatted as `declare private readonly name: string`, matching Prettier and TypeScript's canonical modifier order. - [#11580](biomejs/biome#11580) [`1277af2`](biomejs/biome@1277af2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#5091](biomejs/biome#5091): Biome no longer moves comments next to the `<` of a generic, which causes invalid TypeScript syntax: ```diff - Generic<// a comment + Generic< + // a comment ``` - [#11577](biomejs/biome#11577) [`42995d2`](biomejs/biome@42995d2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#4592](biomejs/biome#4592). Biome no longer crashes while parsing malformed `delete` expressions. - [#11590](biomejs/biome#11590) [`67963b4`](biomejs/biome@67963b4) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6427](biomejs/biome#6427) so Grit plugins can use `function = ...` as a node argument. - [#11600](biomejs/biome#11600) [`a689cb5`](biomejs/biome@a689cb5) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6644](biomejs/biome#6644): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) now recognizes all interface declarations in a TypeScript declaration-merging group when the interface is referenced. The following snippet no longer triggers the rule. ```ts interface Things { foo: string; } interface Things { bar: string; } export type Key = keyof Things; interface Things { baz: string; } ``` - [#11591](biomejs/biome#11591) [`d4a0716`](biomejs/biome@d4a0716) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6615](biomejs/biome#6615). [`noDuplicateProperties`](https://biomejs.dev/linter/rules/no-duplicate-properties/) no longer reports declarations nested in block at-rules as duplicates of declarations in their parent block. - [#11492](biomejs/biome#11492) [`f2a07aa`](biomejs/biome@f2a07aa) Thanks [@santichausis](https://github.com/santichausis)! - Fixed [#11454](biomejs/biome#11454): [`noMisplacedAssertion`](https://biomejs.dev/linter/rules/no-misplaced-assertion/) now recognises `@fast-check/vitest`'s `test.prop(...)` (and `.concurrent.prop`, `.skip.prop`, etc.) as a test function, the same way it already recognises `test.each`. The JS formatter picks up the same recognition, so a curried `test.prop(...)(...)` call is now formatted with the regular breakable argument layout used for `test.each`/`test.for`, instead of the single-line-hugging layout used for plain `it`/`test` calls. For example, Biome no longer reports the assertion below as misplaced: ```js import { fc, test } from "@fast-check/vitest"; test.prop([fc.string()])("round-trips", (s) => { expect(s).toBe(s); }); ``` - [#11589](biomejs/biome#11589) [`65742b3`](biomejs/biome@65742b3) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#4928](biomejs/biome#4928): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports a value declaration as unused when its merged namespace is referenced. - [#11559](biomejs/biome#11559) [`472dbc2`](biomejs/biome@472dbc2) Thanks [@levrik](https://github.com/levrik)! - Fixed a false positive in [`noVueDuplicateKeys`](https://biomejs.dev/linter/rules/no-vue-duplicate-keys/) where a `<script setup>` variable initialized from `props` was reported as a duplicate of the prop it derives from. Biome now exempts any variable whose initializer references `props`, instead of only recognizing `defineProps()` and `toRefs(props)`. For example, Biome no longer reports `foo` below as a duplicate key: ```vue <script setup> import { toRef } from 'vue'; const props = defineProps(['foo']); const foo = toRef(props, 'foo'); </script> ``` - [#11594](biomejs/biome#11594) [`6586ceb`](biomejs/biome@6586ceb) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6640](biomejs/biome#6640). Biome no longer crashes when linting malformed `for...of` statements. - [#11571](biomejs/biome#11571) [`85b197d`](biomejs/biome@85b197d) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10838](biomejs/biome#10838): [`useSortedAttributes`](https://biomejs.dev/assist/actions/use-sorted-attributes/) no longer corrupts JSX attributes when nested JSX elements also require sorting. - [#11533](biomejs/biome#11533) [`97e76c0`](biomejs/biome@97e76c0) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11520](biomejs/biome#11520), where the Biome scanner would start analysing dependencies multiple times, leading to long and unresponsive sessions. - [#11564](biomejs/biome#11564) [`18a0e1f`](biomejs/biome@18a0e1f) Thanks [@Netail](https://github.com/Netail)! - Fixed the diagnostic range of [`noInferrableTypes`](https://biomejs.dev/linter/rules/no-inferrable-types/) so it now highlights only the type instead of including the leading `:` colon, spaces and comments. - [#11540](biomejs/biome#11540) [`124fdaa`](biomejs/biome@124fdaa) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#11537`](biomejs/biome#11537): [`noShorthandPropertyOverrides`](https://biomejs.dev/linter/rules/no-shorthand-property-overrides/) now compares declarations only within the same block. The rule no longer reports `@supports` feature queries and correctly checks nested, `@keyframes`, and `@page` blocks. - [#11532](biomejs/biome#11532) [`7ceb0ee`](biomejs/biome@7ceb0ee) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11528](biomejs/biome#11528): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports statement-level `await` expressions that handle Promise values, including overloaded calls returning Promise aliases. Awaited values that resolve to arrays of Promises remain reported because their element Promises are not handled by `await`. - [#11474](biomejs/biome#11474) [`3c6412e`](biomejs/biome@3c6412e) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10241](biomejs/biome#10241). Biome no longer reports unsupported text expression diagnostics for double-curly text in vanilla HTML, and the formatter preserves adjacent curly-brace text. - [#11593](biomejs/biome#11593) [`6c7fd27`](biomejs/biome@6c7fd27) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noVueDeprecatedScopedSlots`](https://biomejs.dev/linter/rules/no-vue-deprecated-scoped-slots/). It reports deprecated `$scopedSlots` references in Vue templates and component objects, and offers an unsafe replacement with `$slots`. For example, Biome now reports `this.$scopedSlots.default` inside a Vue component. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed the formatter crashing on an Astro or Svelte expression spanning several lines in a file with CRLF line endings, such as `<p>{a +\r\n b}</p>`. - [#11581](biomejs/biome#11581) [`f4e5ebb`](biomejs/biome@f4e5ebb) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useModernMathApis`](https://biomejs.dev/linter/rules/use-modern-math-apis/). The rule reports legacy mathematical patterns that have direct modern `Math` equivalents. ```js Math.sqrt(a * a + b * b); ``` - [#11597](biomejs/biome#11597) [`a20f44a`](biomejs/biome@a20f44a) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noBunModules`](https://biomejs.dev/linter/rules/no-bun-modules/), which forbids the use of Bun builtin modules (e.g. `bun:sqlite`, `bun:ffi`). - [#11545](biomejs/biome#11545) [`7d54688`](biomejs/biome@7d54688) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11542](biomejs/biome#11542): Biome now reports HTML comments between Svelte tag attributes as parse errors. - [#11582](biomejs/biome#11582) [`b6611dd`](biomejs/biome@b6611dd) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#3862](biomejs/biome#3862). Biome now parses legacy Internet Explorer `filter` and `-ms-filter` values such as `progid:DXImageTransform...` and `alpha(opacity=40)`. - [#11575](biomejs/biome#11575) [`65da251`](biomejs/biome@65da251) Thanks [@dyc3](https://github.com/dyc3)! - Improved the Tailwind parser's ability to recover from parsing failures. Whitespace now always allows the parser to recover and start parsing a new class. - [#11576](biomejs/biome#11576) [`0f78499`](biomejs/biome@0f78499) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#3515](biomejs/biome#3515) and [#10395](biomejs/biome#10395), where Biome could corrupt Unicode characters while writing source received through standard input to standard output. Characters such as `⚠` and `✔` are now preserved. - [#11539](biomejs/biome#11539) [`0fca643`](biomejs/biome@0fca643) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11512](biomejs/biome#11512), where [`style/noDescendingSpecificity`](https://biomejs.dev/linter/rules/no-descending-specificity/) missed lower-specificity selectors after a later higher-specificity selector with the same tail selector. - [#11544](biomejs/biome#11544) [`040f867`](biomejs/biome@040f867) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11541](biomejs/biome#11541): formatting a Svelte render tag followed by an HTML comment no longer duplicates the comment. ```diff <div> {@render children?.()}  -  </div> ``` - [#11565](biomejs/biome#11565) [`ee69e0e`](biomejs/biome@ee69e0e) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11525](biomejs/biome#11525). Now the configuration schema correctly provides auto-completion for linter domains. - [#11583](biomejs/biome#11583) [`b19390c`](biomejs/biome@b19390c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11352](biomejs/biome#11352): [`useExplicitLengthCheck`](https://biomejs.dev/linter/rules/use-explicit-length-check/) no longer reports `length`-like properties used as value-producing `||` fallbacks or optional chains, and it no longer offers fixes for value-producing `&&` checks or unsafe negations. - [#11562](biomejs/biome#11562) [`753e955`](biomejs/biome@753e955) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server would start with logging level set to debug. This would cause logs to grow exponentially in long sessions. - [#11217](biomejs/biome#11217) [`7d3ee9c`](biomejs/biome@7d3ee9c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed handling of `biome-ignore format` suppression comments on TypeScript declared class properties with string literal names. ```ts class A { declare /* biome-ignore format: exercise suppression checking */ 'a-b': 0; } ``` - [#11497](biomejs/biome#11497) [`f5d7896`](biomejs/biome@f5d7896) Thanks [@dyc3](https://github.com/dyc3)! - Added the [`noInvalidFileInputAccept`](https://biomejs.dev/linter/rules/no-invalid-file-input-accept/) nursery rule. The rule reports invalid literal `accept` values on file inputs in JSX and HTML, and normalizes common mistakes. ```jsx <input type="file" accept="image/jpg" /> ``` - [#11345](biomejs/biome#11345) [`ac58958`](biomejs/biome@ac58958) Thanks [@jakeleventhal](https://github.com/jakeleventhal)! - Improved type inference performance by avoiding resolution of unused members in object arguments. - [#11554](biomejs/biome#11554) [`2d55931`](biomejs/biome@2d55931) Thanks [@Netail](https://github.com/Netail)! - Added the new nursery rule [`useReactNamingConvention`](https://biomejs.dev/linter/rules/use-react-naming-convention/), which enforces naming conventions for React values assigned from `createContext`, `useId`, and `useRef`. A value from `createContext` must be a PascalCase component name ending with `Context`, a value from `useId` must be named `id` or end with `Id`, and a value from `useRef` must be named `ref` or end with `Ref`. - [#11491](biomejs/biome#11491) [`1d6210b`](biomejs/biome@1d6210b) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noUnmodifiedLoopCondition`](https://biomejs.dev/linter/rules/no-unmodified-loop-condition/), which reports variables in loop conditions that are never modified in the loop. ```js let node = getNode(); while (node) { process(node); } ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Client/pulls/21

This PR contains the following updates: | Package | Type | Update | Change | Pending | |---|---|---|---|---| | [@biomejs/biome](https://biomejs.dev) ([source](https://github.com/biomejs/biome/tree/HEAD/packages/@biomejs/biome)) | imports | patch | [`2.5.11` -> `2.5.12`](https://renovatebot.com/diffs/npm/@biomejs%2fbiome/2.5.11/2.5.12) | `2.5.13` | --- ### Release Notes <details> <summary>biomejs/biome (@biomejs/biome)</summary> ### [`v2.5.12`](https://github.com/biomejs/biome/blob/HEAD/packages/@biomejs/biome/CHANGELOG.md#2512) [Compare Source](https://github.com/biomejs/biome/compare/@biomejs/biome@2.5.11...@biomejs/biome@2.5.12) ##### Patch Changes - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed Astro attribute expressions rejecting TypeScript and JSX syntax that is accepted in text expressions. ```astro <Component icon={<Icon />} count={total as number} onSelect={(e: Event) => e} /> ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed Astro attribute names being split on `:` and `.` inside an expression, such as `{x && <button x-on:keyup.enter={go} client:load.foo />}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a bare `>` in the children of an Astro expression being treated as markup, such as `{x && <div>a > b</div>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed HTML comments inside an Astro expression failing to parse. They are now read as trivia, wherever they appear among the children. ```astro {x && <div>text</div>} {cond && <a></a><b></b>} ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed `is:raw` children inside an Astro expression being read as JSX, such as `{x && <div is:raw>{not js} < & text</div>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed an apostrophe or quote in the text of a JSX element inside an Astro expression ending the expression early, such as `{items.map((i) => <li>it's {i}</li>)}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed the children of a `<script>` or `<style>` inside an Astro expression being read as JSX. Their contents are text, so braces and comparisons no longer have to be escaped. ```astro {cond && <style>a { color: red }</style>} {cond && <script>let x = {a: 1};</script>} ``` - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Added support for template literal attribute values inside an Astro expression, such as ``{x && <C data-x=`t${x}` />}``. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed unquoted attribute values being rejected inside an Astro expression, such as `{x && <a class=foo maxlength=255 href=/about>go</a>}`. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a template literal nested inside `${}` breaking the rest of an Astro file, such as ``const href = `/blog${page === 0 ? '' : `/${page + 1}`}`;``. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed a quote inside a regex character class breaking the rest of an Astro file, such as `const unsafe = /[/"]/;`. - [#11508](biomejs/biome#11508) [`54f3a2e`](biomejs/biome@54f3a2e) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useFlatMathMinMax`](https://biomejs.dev/linter/rules/use-flat-math-min-max/). Because `Math.min()` and `Math.max()` accept any number of arguments, the rule reports unnecessary nested calls to the same method: ```js Math.max(Math.max(a, b), c); ``` The fix flattens this expression to `Math.max(a, b, c)`. - [#11585](biomejs/biome#11585) [`c5c8315`](biomejs/biome@c5c8315) Thanks [@Netail](https://github.com/Netail)! - Fixed [#11475](biomejs/biome#11475): `noUnresolvedImports` no longer reports Bun runtime built-in modules (`bun`, `bun:bundle`, `bun:ffi`, `bun:jsc`, `bun:sqlite`, `bun:test`). - [#11368](biomejs/biome#11368) [`52a57b3`](biomejs/biome@52a57b3) Thanks [@Austin1serb](https://github.com/Austin1serb)! - Fixed [#6830](biomejs/biome#6830): Biome now reports a diagnostic for excessively deep syntax instead of overflowing the native stack while releasing the parsed tree. - [#11596](biomejs/biome#11596) [`1fc42ed`](biomejs/biome@1fc42ed) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noThisOutsideOfClass`](https://biomejs.dev/linter/rules/no-this-outside-of-class/). The rule reports `this` outside class members and TypeScript functions with an explicit `this` parameter. ```js function Person(name) { this.name = name; } ``` - [#11555](biomejs/biome#11555) [`2516335`](biomejs/biome@2516335) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11529](biomejs/biome#11529), where [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) missed unhandled Promise chains when the imported function's module belonged to an import cycle. Cyclic modules now preserve types for exports that do not participate in recursive type dependencies. - [#11518](biomejs/biome#11518) [`0fee70c`](biomejs/biome@0fee70c) Thanks [@HarperZ9](https://github.com/HarperZ9)! - Fixed [#11500](biomejs/biome#11500): the formatter now prints the `declare` modifier before accessibility modifiers on class properties. `private declare readonly name: string` is now formatted as `declare private readonly name: string`, matching Prettier and TypeScript's canonical modifier order. - [#11580](biomejs/biome#11580) [`1277af2`](biomejs/biome@1277af2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#5091](biomejs/biome#5091): Biome no longer moves comments next to the `<` of a generic, which causes invalid TypeScript syntax: ```diff - Generic<// a comment + Generic< + // a comment ``` - [#11577](biomejs/biome#11577) [`42995d2`](biomejs/biome@42995d2) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#4592](biomejs/biome#4592). Biome no longer crashes while parsing malformed `delete` expressions. - [#11590](biomejs/biome#11590) [`67963b4`](biomejs/biome@67963b4) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6427](biomejs/biome#6427) so Grit plugins can use `function = ...` as a node argument. - [#11600](biomejs/biome#11600) [`a689cb5`](biomejs/biome@a689cb5) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6644](biomejs/biome#6644): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) now recognizes all interface declarations in a TypeScript declaration-merging group when the interface is referenced. The following snippet no longer triggers the rule. ```ts interface Things { foo: string; } interface Things { bar: string; } export type Key = keyof Things; interface Things { baz: string; } ``` - [#11591](biomejs/biome#11591) [`d4a0716`](biomejs/biome@d4a0716) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6615](biomejs/biome#6615). [`noDuplicateProperties`](https://biomejs.dev/linter/rules/no-duplicate-properties/) no longer reports declarations nested in block at-rules as duplicates of declarations in their parent block. - [#11492](biomejs/biome#11492) [`f2a07aa`](biomejs/biome@f2a07aa) Thanks [@santichausis](https://github.com/santichausis)! - Fixed [#11454](biomejs/biome#11454): [`noMisplacedAssertion`](https://biomejs.dev/linter/rules/no-misplaced-assertion/) now recognises `@fast-check/vitest`'s `test.prop(...)` (and `.concurrent.prop`, `.skip.prop`, etc.) as a test function, the same way it already recognises `test.each`. The JS formatter picks up the same recognition, so a curried `test.prop(...)(...)` call is now formatted with the regular breakable argument layout used for `test.each`/`test.for`, instead of the single-line-hugging layout used for plain `it`/`test` calls. For example, Biome no longer reports the assertion below as misplaced: ```js import { fc, test } from "@fast-check/vitest"; test.prop([fc.string()])("round-trips", (s) => { expect(s).toBe(s); }); ``` - [#11589](biomejs/biome#11589) [`65742b3`](biomejs/biome@65742b3) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#4928](biomejs/biome#4928): [`noUnusedVariables`](https://biomejs.dev/linter/rules/no-unused-variables/) no longer reports a value declaration as unused when its merged namespace is referenced. - [#11559](biomejs/biome#11559) [`472dbc2`](biomejs/biome@472dbc2) Thanks [@levrik](https://github.com/levrik)! - Fixed a false positive in [`noVueDuplicateKeys`](https://biomejs.dev/linter/rules/no-vue-duplicate-keys/) where a `<script setup>` variable initialized from `props` was reported as a duplicate of the prop it derives from. Biome now exempts any variable whose initializer references `props`, instead of only recognizing `defineProps()` and `toRefs(props)`. For example, Biome no longer reports `foo` below as a duplicate key: ```vue <script setup> import { toRef } from 'vue'; const props = defineProps(['foo']); const foo = toRef(props, 'foo'); </script> ``` - [#11594](biomejs/biome#11594) [`6586ceb`](biomejs/biome@6586ceb) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#6640](biomejs/biome#6640). Biome no longer crashes when linting malformed `for...of` statements. - [#11571](biomejs/biome#11571) [`85b197d`](biomejs/biome@85b197d) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#10838](biomejs/biome#10838): [`useSortedAttributes`](https://biomejs.dev/assist/actions/use-sorted-attributes/) no longer corrupts JSX attributes when nested JSX elements also require sorting. - [#11533](biomejs/biome#11533) [`97e76c0`](biomejs/biome@97e76c0) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11520](biomejs/biome#11520), where the Biome scanner would start analysing dependencies multiple times, leading to long and unresponsive sessions. - [#11564](biomejs/biome#11564) [`18a0e1f`](biomejs/biome@18a0e1f) Thanks [@Netail](https://github.com/Netail)! - Fixed the diagnostic range of [`noInferrableTypes`](https://biomejs.dev/linter/rules/no-inferrable-types/) so it now highlights only the type instead of including the leading `:` colon, spaces and comments. - [#11540](biomejs/biome#11540) [`124fdaa`](biomejs/biome@124fdaa) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [`#11537`](biomejs/biome#11537): [`noShorthandPropertyOverrides`](https://biomejs.dev/linter/rules/no-shorthand-property-overrides/) now compares declarations only within the same block. The rule no longer reports `@supports` feature queries and correctly checks nested, `@keyframes`, and `@page` blocks. - [#11532](biomejs/biome#11532) [`7ceb0ee`](biomejs/biome@7ceb0ee) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11528](biomejs/biome#11528): [`noFloatingPromises`](https://biomejs.dev/linter/rules/no-floating-promises/) no longer reports statement-level `await` expressions that handle Promise values, including overloaded calls returning Promise aliases. Awaited values that resolve to arrays of Promises remain reported because their element Promises are not handled by `await`. - [#11474](biomejs/biome#11474) [`3c6412e`](biomejs/biome@3c6412e) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#10241](biomejs/biome#10241). Biome no longer reports unsupported text expression diagnostics for double-curly text in vanilla HTML, and the formatter preserves adjacent curly-brace text. - [#11593](biomejs/biome#11593) [`6c7fd27`](biomejs/biome@6c7fd27) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noVueDeprecatedScopedSlots`](https://biomejs.dev/linter/rules/no-vue-deprecated-scoped-slots/). It reports deprecated `$scopedSlots` references in Vue templates and component objects, and offers an unsafe replacement with `$slots`. For example, Biome now reports `this.$scopedSlots.default` inside a Vue component. - [#11440](biomejs/biome#11440) [`b88f1ea`](biomejs/biome@b88f1ea) Thanks [@Princesseuh](https://github.com/Princesseuh)! - Fixed the formatter crashing on an Astro or Svelte expression spanning several lines in a file with CRLF line endings, such as `<p>{a +\r\n b}</p>`. - [#11581](biomejs/biome#11581) [`f4e5ebb`](biomejs/biome@f4e5ebb) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`useModernMathApis`](https://biomejs.dev/linter/rules/use-modern-math-apis/). The rule reports legacy mathematical patterns that have direct modern `Math` equivalents. ```js Math.sqrt(a * a + b * b); ``` - [#11597](biomejs/biome#11597) [`a20f44a`](biomejs/biome@a20f44a) Thanks [@Netail](https://github.com/Netail)! - Added the nursery rule [`noBunModules`](https://biomejs.dev/linter/rules/no-bun-modules/), which forbids the use of Bun builtin modules (e.g. `bun:sqlite`, `bun:ffi`). - [#11545](biomejs/biome#11545) [`7d54688`](biomejs/biome@7d54688) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11542](biomejs/biome#11542): Biome now reports HTML comments between Svelte tag attributes as parse errors. - [#11582](biomejs/biome#11582) [`b6611dd`](biomejs/biome@b6611dd) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#3862](biomejs/biome#3862). Biome now parses legacy Internet Explorer `filter` and `-ms-filter` values such as `progid:DXImageTransform...` and `alpha(opacity=40)`. - [#11575](biomejs/biome#11575) [`65da251`](biomejs/biome@65da251) Thanks [@dyc3](https://github.com/dyc3)! - Improved the Tailwind parser's ability to recover from parsing failures. Whitespace now always allows the parser to recover and start parsing a new class. - [#11576](biomejs/biome#11576) [`0f78499`](biomejs/biome@0f78499) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#3515](biomejs/biome#3515) and [#10395](biomejs/biome#10395), where Biome could corrupt Unicode characters while writing source received through standard input to standard output. Characters such as `⚠` and `✔` are now preserved. - [#11539](biomejs/biome#11539) [`0fca643`](biomejs/biome@0fca643) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11512](biomejs/biome#11512), where [`style/noDescendingSpecificity`](https://biomejs.dev/linter/rules/no-descending-specificity/) missed lower-specificity selectors after a later higher-specificity selector with the same tail selector. - [#11544](biomejs/biome#11544) [`040f867`](biomejs/biome@040f867) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11541](biomejs/biome#11541): formatting a Svelte render tag followed by an HTML comment no longer duplicates the comment. ```diff <div> {@render children?.()}  -  </div> ``` - [#11565](biomejs/biome#11565) [`ee69e0e`](biomejs/biome@ee69e0e) Thanks [@ematipico](https://github.com/ematipico)! - Fixed [#11525](biomejs/biome#11525). Now the configuration schema correctly provides auto-completion for linter domains. - [#11583](biomejs/biome#11583) [`b19390c`](biomejs/biome@b19390c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed [#11352](biomejs/biome#11352): [`useExplicitLengthCheck`](https://biomejs.dev/linter/rules/use-explicit-length-check/) no longer reports `length`-like properties used as value-producing `||` fallbacks or optional chains, and it no longer offers fixes for value-producing `&&` checks or unsafe negations. - [#11562](biomejs/biome#11562) [`753e955`](biomejs/biome@753e955) Thanks [@ematipico](https://github.com/ematipico)! - Fixed an issue where the Biome Language Server would start with logging level set to debug. This would cause logs to grow exponentially in long sessions. - [#11217](biomejs/biome#11217) [`7d3ee9c`](biomejs/biome@7d3ee9c) Thanks [@dyc3](https://github.com/dyc3)! - Fixed handling of `biome-ignore format` suppression comments on TypeScript declared class properties with string literal names. ```ts class A { declare /* biome-ignore format: exercise suppression checking */ 'a-b': 0; } ``` - [#11497](biomejs/biome#11497) [`f5d7896`](biomejs/biome@f5d7896) Thanks [@dyc3](https://github.com/dyc3)! - Added the [`noInvalidFileInputAccept`](https://biomejs.dev/linter/rules/no-invalid-file-input-accept/) nursery rule. The rule reports invalid literal `accept` values on file inputs in JSX and HTML, and normalizes common mistakes. ```jsx <input type="file" accept="image/jpg" /> ``` - [#11345](biomejs/biome#11345) [`ac58958`](biomejs/biome@ac58958) Thanks [@jakeleventhal](https://github.com/jakeleventhal)! - Improved type inference performance by avoiding resolution of unused members in object arguments. - [#11554](biomejs/biome#11554) [`2d55931`](biomejs/biome@2d55931) Thanks [@Netail](https://github.com/Netail)! - Added the new nursery rule [`useReactNamingConvention`](https://biomejs.dev/linter/rules/use-react-naming-convention/), which enforces naming conventions for React values assigned from `createContext`, `useId`, and `useRef`. A value from `createContext` must be a PascalCase component name ending with `Context`, a value from `useId` must be named `id` or end with `Id`, and a value from `useRef` must be named `ref` or end with `Ref`. - [#11491](biomejs/biome#11491) [`1d6210b`](biomejs/biome@1d6210b) Thanks [@dyc3](https://github.com/dyc3)! - Added the nursery rule [`noUnmodifiedLoopCondition`](https://biomejs.dev/linter/rules/no-unmodified-loop-condition/), which reports variables in loop conditions that are never modified in the loop. ```js let node = getNode(); while (node) { process(node); } ``` </details> --- ### Configuration 📅 **Schedule**: (UTC) - Branch creation - At any time (no schedule defined) - Automerge - At any time (no schedule defined) 🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate CLI](https://github.com/renovatebot/renovate).  Reviewed-on: https://git.oirnoir.dev/OIRNOIR/YouTube-Helper-Server/pulls/43

fix(noDuplicateProperties): handle function named

08cebc2

ematipico requested review from a team September 2, 2026 09:26

github-actions Bot added A-Project Area: project A-Linter Area: linter L-CSS Language: CSS and super languages labels Sep 2, 2026

dyc3 approved these changes Sep 2, 2026

View reviewed changes

ematipico merged commit d4a0716 into main Sep 2, 2026
35 checks passed

ematipico deleted the fix/no-duplicate-properties branch September 2, 2026 11:46

github-actions Bot mentioned this pull request Sep 2, 2026

ci: release #11530

Merged

Navigation Menu

Uh oh!

fix(noDuplicateProperties): handle function named - #11591

fix(noDuplicateProperties): handle function named#11591
ematipico merged 1 commit into
mainfrom
fix/no-duplicate-properties

ematipico commented Sep 2, 2026

Uh oh!

changeset-bot Bot commented Sep 2, 2026

Uh oh!

coderabbitai Bot commented Sep 2, 2026

Uh oh!

codspeed Bot commented Sep 2, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

ematipico commented Sep 2, 2026

Summary

Test Plan

Docs

Uh oh!

changeset-bot Bot commented Sep 2, 2026

🦋 Changeset detected

Uh oh!

coderabbitai Bot commented Sep 2, 2026

Walkthrough

Uh oh!

codspeed Bot commented Sep 2, 2026

Merging this PR will not alter performance

Footnotes

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants