Conversation
- Detect unguarded browser globals in top-level Vue and Svelte scripts - Add configuration, diagnostics, fixtures, snapshots, and changeset
🦋 Changeset detectedLatest commit: 04f1af2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 13 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Essentials Run ID: ⛔ Files ignored due to path filters (26)
📒 Files selected for processing (26)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. WalkthroughAdds the Merge Risk: ⚪ Minimal · up to The new rule, options export, and fixtures have no identified merge-blocking risk. 🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
Merging this PR will not alter performance
Comparing Footnotes
|
ematipico
reviewed
Sep 6, 2026
ematipico
left a comment
Member
There was a problem hiding this comment.
IMHO, as it is, the rule is a bit limited. I believe we can make it more powerful if we make it a project rule, and we inspect the also the modules imported by a component.
The moment you move the unguarded global into a simple file, and import it inside the component, the rule cease to function
| use biome_rule_options::no_top_level_browser_globals::NoTopLevelBrowserGlobalsOptions; | ||
|
|
||
| declare_lint_rule! { | ||
| /// Disallow unguarded browser globals at the top level of Vue and Svelte scripts. |
dyc3
marked this pull request as draft
September 17, 2026 17:33
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
this pr adds noTopLevelBrowserGlobals, a cross framework rule intended to protect projects that use server side rendering.
inspired by (and pretty much an expanded scope port of) https://sveltejs.github.io/eslint-plugin-svelte/rules/no-top-level-browser-globals/
implemented by astra
Test Plan
snapshots
Docs