Skip to content

fix(lsp): compute results against the requesting client's text when a… - #11829

Draft
saberoueslati wants to merge 1 commit into
biomejs:mainfrom
saberoueslati:lsp/fix-multi-client-formatting-corruption
Draft

saberoueslati wants to merge 1 commit into
biomejs:mainfrom
saberoueslati:lsp/fix-multi-client-formatting-corruption

Conversation

@saberoueslati

Copy link
Copy Markdown
Contributor

Fixes #11767

@changeset-bot

changeset-bot Bot commented Sep 17, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 7354dd9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 13 packages
Name Type
@biomejs/biome Patch
@biomejs/cli-darwin-arm64 Patch
@biomejs/cli-darwin-x64 Patch
@biomejs/cli-linux-arm64-musl Patch
@biomejs/cli-linux-arm64 Patch
@biomejs/cli-linux-x64-musl Patch
@biomejs/cli-linux-x64 Patch
@biomejs/cli-win32-arm64 Patch
@biomejs/cli-win32-x64 Patch
@biomejs/wasm-bundler Patch
@biomejs/wasm-nodejs Patch
@biomejs/wasm-web Patch
@biomejs/backend-jsonrpc Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@agentscanapp

agentscanapp Bot commented Sep 17, 2026

Copy link
Copy Markdown

A maintainer will take a look as soon as they can. In the meantime, please make sure that:

  • the description follows our PR template
  • any related issues are linked
  • existing tests still pass

@github-actions github-actions Bot added A-Project Area: project A-LSP Area: language server protocol labels Sep 17, 2026
@saberoueslati
saberoueslati force-pushed the lsp/fix-multi-client-formatting-corruption branch from 98acf4b to 7354dd9 Compare September 23, 2026 16:11
@codspeed

codspeed Bot commented Sep 23, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 9 untouched benchmarks
⏩ 351 skipped benchmarks1


Comparing saberoueslati:lsp/fix-multi-client-formatting-corruption (7354dd9) with main (4a32975)

Open in CodSpeed

Footnotes

  1. 351 benchmarks were skipped, so the baseline results were used instead. If they were deleted from the codebase, click here and archive them to remove them from the performance reports.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-LSP Area: language server protocol A-Project Area: project

Projects

None yet

Development

Successfully merging this pull request may close these issues.

🐛 2 clients formatting the same file can cause corruption

1 participant