-
Notifications
You must be signed in to change notification settings - Fork 138
Add importer for 1Password's new export format (.1pux) #594
Conversation
|
Are we requiring users to unzip the file themselves before running our importer? |
Not sure yet, wanna see if we are able to upload/unzip it in the web client and pass on the export.data to the importer. That would be the prefered solution. |
|
Curious as to how this handles TOTP for free account imports; If we import to a free account, is that data saved and it is later unlocked for the user if they upgrade? |
Yes, the TOTP field from 1P contains the seed value and it gets persisted in the cipher. Once the user purchases premium we start generating TOTP codes. Just verified this with my local test instance |
common/src/importers/onepasswordImporters/onepassword1PuxImporter.ts
Outdated
Show resolved
Hide resolved
common/src/importers/onepasswordImporters/onepassword1PuxImporter.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great, love the super thorough tests!
Thank you, was loads of work, but this will hopefully aid, if users encounter any issues and encourage devs to add more tests 😉 |
Type of change
Objective
With 1Password changing their export format from
.1pifto.1puxin recent versions, this adds an importer to import 1pux into Bitwarden.The 1pux format is essentially a zip archive including multiple files. The initial one of interest is the
export.datafile which contains the vault data.Further information about the new 1pux format can be found here: https://support.1password.com/1pux-format/
Rough overview of imported ciphers/fields:
Trashed items are ignored
Empty fields are skipped
Login items
CreditCard items
Identity items
Import of custom fields (loginfields and sections) for all CipherTypes
Favorites are set
Import into folders based on the first entry in tags
Import into collection based on the first entry in tags, if the import is ran from within an organization
Folder and Collection names are captialized
Category Mappings
1password supports various categories (Item types) which are saved in categoryUuid and are mapped as the following:
Bitwarden Login Type:
Bitwarden CreditCard Type:
Bitwarden Secure Note:
Bitwarden Identity Type:
1pux is prepared for including attachments but as of now, they are not included. This will be handled at a later point when 1password has added this feature.
Asana task: https://app.asana.com/0/1153292148278596/1201437354678085/f
Code changes
export.datafileexport.dataimporter for parsing and importing vaults.Testing requirements
Test scenarios will be listed on the web PR.
Before you submit
npm run lint) (required)