Skip to content
This repository was archived by the owner on Jun 17, 2022. It is now read-only.

Conversation

@eliykat
Copy link
Member

@eliykat eliykat commented Mar 1, 2022

Type of change

  • Bug fix
  • New feature development
  • Tech debt (refactoring, code cleanup, dependency upgrades, etc)
  • Build/deploy pipeline (DevOps)
  • Other

Objective

  1. SAML Artifact Binding settings were removed in CSA-6 Remove artifact binding from SSO config UI web#1502 and CSA-6 Fix/remove artifact binding server#1885, but still remained in the SsoConfigApi model, and I accidentally reintroduced some in Improve SSO Config validation #572.

  2. Clean up some unused code that I didn't end up needing in the SSO Config Form refactor.

Code changes

  1. Remove unused properties and enum value.
  2. Remove unused validators.

Testing requirements

Will be covered by general regression testing and testing of bitwarden/web#1332 once merged.

Before you submit

  • I have checked for linting errors (npm run lint) (required)
  • I have added unit tests where it makes sense to do so (encouraged but not required)
  • This change requires a documentation update (notify the documentation team)
  • This change has particular deployment requirements (notify the DevOps team)

@eliykat eliykat requested a review from a team March 1, 2022 22:32
@eliykat eliykat changed the title Remove unused SAML Artifact Binding properties Remove unused SSO Mar 1, 2022
@eliykat eliykat changed the title Remove unused SSO Remove unused SSO Form code Mar 1, 2022
@eliykat eliykat merged commit adfc2f2 into master Mar 2, 2022
@eliykat eliykat deleted the fix/remove-artifact branch March 2, 2022 21:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants