docs: add coupling to the --report-skip section list - #778
Open
NotAFlightRisk wants to merge 1 commit into
Open
NotAFlightRisk wants to merge 1 commit into
NotAFlightRisk wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I went to drop the coupling section out of
scc --reportand the table in the README says you cant - every other section is in that list, coupling isn't. It works fine though, the table is just short a name. Passing a bogus section prints the real set:The rest of the README has it right - the
-hpaste further up lists all ten, and the sentence directly under the table names coupling as one of the git-history sections. So it's only the table thats out of step. I've added it afterhotspots, which is where the help puts it.The same nine names in the same order also turn up in
TestParseReportSkipKnownNames, under a comment saying it parses every recognised one.TestReportSkipRecognisedListMatchesSpecfurther down does have all ten and locks the size, so the set itself can't drift. Left that alone, it's a test rather than a doc.I explicitly licence this contribution under the MIT licence.