Repository navigation
feat: integrate Codex project workflows - #307
Merged
Merged
Conversation
branover
commented
Aug 13, 2026
branover
left a comment
Owner
Author
There was a problem hiding this comment.
APPROVE
Independent HexGraph merge-gate review for PR #307.
Findings: none.
Correctness and test-quality pass
- Reviewed both the GitHub PR diff and
origin/main...HEAD, including the setup wizard, refresh expansion, native skill paths, Codex hook/custom-agent configuration, shared UX skill symlink, documentation, and tests. - The setup wizard retains explicit opt-in, then installs the generated bundle for every detected Claude Code/Codex executable. A missing native user-level copy is added on refresh only after an existing native copy proves prior opt-in; project-local installs remain project-local.
- Current official OpenAI documentation confirms Codex's
$HOME/.agents/skills, repository.agents/skills, project.codex/hooks.json, and.codex/agents/*.tomldiscovery paths. It also confirmsAgentmatching forspawn_agent, thetool_inputpayload, and the PreToolUse deny response used here. - Verification:
122 passed, 1 skippedfortests/test_setup_wizard.py,tests/test_setup_refresh.py,tests/test_mcp.py, andtests/test_vr_skill.py;git diff --checkpassed; Codex JSON/TOML parsed; hook shell syntax and allow/deny payload smoke tests passed; the shared skill is committed as a symlink.
Security and repository-invariant pass
- The change does not bind a service, process hostile target bytes, execute targets, add network access, rehost firmware, or touch policy seams. The loopback, sandbox, secret-handling, and explicit execution/network/rehosting gates are unchanged.
- The generated skill and agent configuration contain no secret or real-engagement data.
.codex/memoriesis explicitly ignored, preserving the public-repository confidentiality boundary. - User-facing setup/MCP behavior is documented in the README and feature docs. There is no UI behavior or data-model change, so
docs/dev/ux-contract.mdand a migration are not required.
Required CI was still running when this review was posted; merge must continue to wait for the repository's required checks and thread-resolution gate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
.agents/skillslocationhexgraph-vrbundle into every detected Claude Code and Codex user-level skill directory after one explicit setup opt-injust refreshadd a missing native Claude/Codex copy after a prior user-level skill opt-in, while preserving project-local behaviorWhy
HexGraph already supported Codex as an MCP client, but its reusable VR skill lifecycle was Claude-only and the repository's agent workflow was not available to Codex. This keeps one skill source and one project policy while using each client's native discovery path.
Verification
python -m pytest -q tests/test_setup_wizard.py tests/test_setup_refresh.py tests/test_mcp.py tests/test_vr_skill.py(122 passed, 1 skipped)hexgraph-vrbundle.agents/skills/ux-assessmentbash -n .claude/hooks/guard-pr-reviewer.shpr_reviewerversus a generic reviewer task.codex/hooks.jsonparsed withjq;.codex/agents/pr-reviewer.tomlparsed withtomllibgit diff --checkThe broader foreground pytest run was stopped after an existing unrelated test made no progress for several minutes. Required CI remains the merge gate.