Cython eventseg - #111
Merged
Merged
Conversation
Member
|
Add the correspondingly compiled |
added 2 commits
September 23, 2016 10:23
Member
|
Jenkins, retest this please. |
Also, simplify pybind11 include dirs usage and remove cython and pybind11 from the install dependencies.
Travis tests fail otherwise.
Travis tests fail otherwise.
Member
|
@cbaldassano Could you please review this PR? |
cbaldassano
approved these changes
Oct 3, 2016
cbaldassano
left a comment
Collaborator
There was a problem hiding this comment.
Looks good to me, really impressed at how much of a difference this made!
Add NumPy include dirs to setup
mihaic
approved these changes
Oct 3, 2016
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added cython module for the _log function which speeds up examples/eventseg/simulated_data.py by 2.8X on my machine (Intel(R) Xeon(R) CPU E5-2699 v3 @ 2.30GHz, Python 3.4.3 (default, Jan 26 2016, 02:25:35) [GCC 4.8.5 20150623 (Red Hat 4.8.5-4)] on linux)
time python3 simulated_data.py
Before:
real 0m10.687s
user 0m11.325s
sys 0m6.733s
After:
real 0m3.811s
user 0m4.466s
sys 0m6.722s