Skip to content

add ball shape searchlight#348

Merged
mihaic merged 4 commits into
brainiak:masterfrom
lcnature:searchlight_ball
Mar 23, 2018
Merged

add ball shape searchlight#348
mihaic merged 4 commits into
brainiak:masterfrom
lcnature:searchlight_ball

Conversation

@lcnature

Copy link
Copy Markdown
Contributor

No description provided.

@mjanderson09

Copy link
Copy Markdown
Contributor

Looks good!

(Pdb) print(b.mask_[3,:])
[[False False False False False False False False False False False]
[False False False True True True True True False False False]
[False False True True True True True True True False False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False True True True True True True True True True False]
[False False True True True True True True True False False]
[False False False True True True True True False False False]
[False False False False False False False False False False False]]

Comment thread brainiak/searchlight/searchlight.py Outdated


class Ball(Shape):
"""Diamond

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"Ball searchlight shape"?

…to or less than rad instead of just less than. So I just updated the docstring slightly. Please double check this is correct
@mihaic

mihaic commented Mar 22, 2018

Copy link
Copy Markdown
Member

@lcnature, regardless of your off-by-one question (@mjanderson09?), please add unit tests for the new Ball class to pass the coverage check.

@lcnature

Copy link
Copy Markdown
Contributor Author

@mihaic Done. Thanks!

@mihaic mihaic merged commit 83e6cf7 into brainiak:master Mar 23, 2018
@mihaic

mihaic commented Mar 23, 2018

Copy link
Copy Markdown
Member

Thanks, @lcnature. I am sure your Ball shape will be very popular.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants