syntax: Fix Python 3.6 string escape deprecation - #389
Merged
Conversation
From Python 3.6 release notes: "A backslash-character pair that is not a valid escape sequence now generates a DeprecationWarning. Although this will eventually become a SyntaxError, that will not be for several Python releases." https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior This became a run-checks.sh error and was causing builds to fail in PR brainiak#387 starting with pycodestyle 2.4.0: https://pycodestyle.readthedocs.io/en/latest/developer.html
lcnature
approved these changes
Oct 24, 2018
lcnature
left a comment
Contributor
There was a problem hiding this comment.
Since all the changes are related to backslashes, this looks good.
Member
Author
|
FYI, this is why the Conda builds are failing on Travis: As far as I can see on the Matplotlib email list, they will only release a version incorporating the fix next weekend, so I am making the test non-blocking until then. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
From Python 3.6 release notes:
"A backslash-character pair that is not a valid escape sequence now
generates a DeprecationWarning. Although this will eventually become a
SyntaxError, that will not be for several Python releases."
https://docs.python.org/3/whatsnew/3.6.html#deprecated-python-behavior
This became a run-checks.sh error and was causing builds to fail in PR #387 starting with pycodestyle 2.4.0:
https://pycodestyle.readthedocs.io/en/latest/developer.html