fmrisim: Fix numpy.matlib import#403
Merged
lcnature merged 1 commit intobrainiak:masterfrom Jan 13, 2019
Merged
Conversation
Importing NumPy does not import the `matlib` module. It was implicitly imported by SciPy, but this changed in SciPy version 1.2.0: https://github.com/scipy/scipy/pull/9302/files#diff-99684e0fbbb74e008ca6a5c1196adf37
lcnature
approved these changes
Jan 13, 2019
Contributor
lcnature
left a comment
There was a problem hiding this comment.
Thanks for finding the solution to the test error!
mihaic
added a commit
to mihaic/brainiak
that referenced
this pull request
Apr 8, 2019
This will add it to the next release, not v0.8, as it should be. In PR brainiak#403, I mistakenly suggested editing NEWS directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Importing NumPy does not import the
matlibmodule. It was implicitlyimported by SciPy, but this changed in SciPy version 1.2.0:
https://github.com/scipy/scipy/pull/9302/files#diff-99684e0fbbb74e008ca6a5c1196adf37