Skip to content

dev: Remove obsolete Theano NumPy workaround#414

Merged
gdoubleyew merged 1 commit into
brainiak:masterfrom
mihaic:unpin-numpy
Mar 11, 2019
Merged

dev: Remove obsolete Theano NumPy workaround#414
gdoubleyew merged 1 commit into
brainiak:masterfrom
mihaic:unpin-numpy

Conversation

@mihaic

@mihaic mihaic commented Mar 5, 2019

Copy link
Copy Markdown
Member

Workaround in PR #408 obsoleted by Theano 1.0.4.

Workaround in PR brainiak#408 obsoleted by Theano 1.0.4.
@mihaic

mihaic commented Mar 5, 2019

Copy link
Copy Markdown
Member Author

@snastase, PR #405 will be blocked by a Jenkins error until this PR is merged (once you fix the current duplicate citation error). Can you please review?

@gdoubleyew gdoubleyew left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@gdoubleyew
gdoubleyew merged commit 17792c8 into brainiak:master Mar 11, 2019
@mihaic
mihaic deleted the unpin-numpy branch March 11, 2019 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants