Skip to content

dev: Add coverage threshold for patch#415

Merged
mihaic merged 2 commits into
brainiak:masterfrom
mihaic:coverage-patch-threshold
Apr 10, 2019
Merged

dev: Add coverage threshold for patch#415
mihaic merged 2 commits into
brainiak:masterfrom
mihaic:coverage-patch-threshold

Conversation

@mihaic

@mihaic mihaic commented Mar 18, 2019

Copy link
Copy Markdown
Member

No description provided.

@mihaic

mihaic commented Mar 18, 2019

Copy link
Copy Markdown
Member Author

@snastase, this should allow your PR #405 to pass (I'm not sure because Codecov documentation is very poor), in case your new tests don't do it.

@SILISTechnologies10-18

Copy link
Copy Markdown

I am muting this ignorant chat threads and they are still coming through?!

@snastase snastase left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not an expert in this, but seems practical as long as it's not abused.

@mihaic

mihaic commented Apr 10, 2019

Copy link
Copy Markdown
Member Author

Jenkins, retest this please.

@mihaic
mihaic merged commit 4dba500 into brainiak:master Apr 10, 2019
@mihaic
mihaic deleted the coverage-patch-threshold branch April 10, 2019 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants