dev: Add brainiak-tutorials to Dockerfile#425
Conversation
Move to Ubuntu 18.04 for Python 3.6, required for tutorials.
| && echo "shell -bash" >> ~/.screenrc | ||
|
|
||
| EXPOSE 8888 | ||
| EXPOSE 8899 |
There was a problem hiding this comment.
Didn't we want to stay with port 8888 because that is what Jupiter prints as the URL when it starts? I remember users getting confused by that.
There was a problem hiding this comment.
This is consistent with the script that we run automatically, so Jupyter will print the right thing:
https://github.com/brainiak/brainiak-tutorials/blob/master/tutorials/run_jupyter_docker.sh#L2
| EXPOSE 8899 | ||
|
|
||
| ENTRYPOINT ["/bin/bash", "-l"] | ||
| CMD ["tutorials/run_jupyter_docker.sh"] |
There was a problem hiding this comment.
Do we want the tutorials to automatically start? Seems like most of the time the user of brainiak docker will not be using the tutorials.
There was a problem hiding this comment.
I think the tutorials are a great way to start for all users of BrainIAK. At the same time, we should add instructions to the website about starting a shell (hint: add -c bash at the end of the docker run command).
| && tar -xf brainiak-*.tar.gz \ | ||
| && for example in brainiak-$BRAINIAK_VERSION/examples/*/requirements.txt; \ | ||
| && python3 -m pip install --user -U "pip<10" \ | ||
| && python3 -m pip install --user -U . \ |
There was a problem hiding this comment.
For clarity I'd prefer to have WORKDIR /mnt and
&& python3 -m pip install --user -U brainiak
&& python3 -m pip install --user -U -r brainiak/tutorials/requirements.txt
&& for example in brainiak/examples/*/requirements.txt; \
There was a problem hiding this comment.
From the user perspective, I think WORKDIR should be brainiak, so users can easily find the tutorials and examples. As for clarity in the Dockerfile for developers, I think developers are used to working inside the brainiak directory.
Move to Ubuntu 18.04 for Python 3.6, required for tutorials.