Allowing the sl_rad parameter in searchlight to be 0 - #440
Merged
Conversation
Member
|
I hope the Conda build problem is intermittent and it will be gone on Monday. :) Will review then. |
Contributor
|
Happy to review this once those issues are resolved |
Contributor
Author
|
Awesome! @CameronTEllis you are welcome to review it as well. The changes are minor. |
Merged
Member
|
@CameronTEllis, you can review; the errors are unrelated. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are use cases in which we want to do the same processing on all voxels and want to use MPI to parallelize this. In this case, the searchlight has the size of 1, and it corresponds to
sl_rad = 0when initializingSearchLight. But the current implementation will distribute an empty array to each worker if we setsl_rad = 0. The consequence is that nothing gets computed for each voxel. This PR fixes this bug.