Unpin scikit-learn and set gamma to auto in SVC tests#461
Merged
Conversation
Collaborator
|
Can one of the admins verify this patch? |
1 similar comment
Collaborator
|
Can one of the admins verify this patch? |
Member
|
Jenkins, add to whitelist. |
Member
|
This looks great! Thanks, @ariekahn. Could you please change the example code as well, in |
mihaic
approved these changes
May 5, 2020
Member
|
Thank you very much for your contribution, @ariekahn. It's great to not have to keep this important dependency pinned. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #448
scikit-learn 0.22 changed the default value of
gammainSVCto 'scale' from 'auto' (see https://scikit-learn.org/stable/modules/generated/sklearn.svm.SVC.html). This PR should hopefulyl fix the tests using SVC by explicitly setting gamma to 'auto' in line with previous behavior.