Fix pairwise bootstrap to tolerate NaNs - #475
Merged
Merged
Conversation
CameronTEllis
self-requested a review
August 10, 2020 18:09
CameronTEllis
approved these changes
Aug 31, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is intended to fix issue #472 raised by @yibeichan (thanks!). We had some redundant
assertstatements for checking thatsquareformcorrectly returns a square/symmetric pairwise ISC matrix; however, one of the assertions gets intentionally violated when the ISC inputs contained NaNs. Here we remove the superfluousassertstatements, which fixes the issue with NaNs; and also useforce='tomatrix'in thesquareformcall to make the desired output more obvious.