adding save/load functionality to funcalign/srm - #484
Merged
Conversation
Member
|
@me-sh, thank you for the PR! Please add tests. See the other SRM tests: |
snastase
self-requested a review
October 13, 2020 17:15
Contributor
|
I made some minor adjustments and added a test of the SRM save/load functionality here: me-sh#1 (not sure how to commit changes more directly to this PR) |
Member
Member
|
Because we are planning to make a release very soon, I will add @snastase's commits to this PR and merge it. |
Contributor
Author
mihaic
approved these changes
Oct 14, 2020
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding save/load functionality to funcalign/srm to resolve issue #428