Skip to content

adding save/load functionality to funcalign/srm - #484

Merged
mihaic merged 8 commits into
brainiak:masterfrom
me-sh:save_srm
Oct 14, 2020
Merged

adding save/load functionality to funcalign/srm#484
mihaic merged 8 commits into
brainiak:masterfrom
me-sh:save_srm

Conversation

@me-sh

@me-sh me-sh commented Oct 10, 2020

Copy link
Copy Markdown
Contributor

Adding save/load functionality to funcalign/srm to resolve issue #428

@mihaic

mihaic commented Oct 12, 2020

Copy link
Copy Markdown
Member

@me-sh, thank you for the PR! Please add tests. See the other SRM tests:
https://github.com/brainiak/brainiak/blob/master/tests/funcalign/test_srm.py
You can use the Pytest tmp_path fixture to obtain an output directory:
https://docs.pytest.org/en/latest/tmpdir.html#the-tmp-path-fixture

@snastase
snastase self-requested a review October 13, 2020 17:15
@snastase

Copy link
Copy Markdown
Contributor

I made some minor adjustments and added a test of the SRM save/load functionality here: me-sh#1 (not sure how to commit changes more directly to this PR)

@mihaic

mihaic commented Oct 13, 2020

Copy link
Copy Markdown
Member

Thanks, @snastase! You should be able to push your branch to @me-sh's.

git remote add me-sh https://github.com/me-sh/brainiak
git fetch me-sh
git push me-sh

@mihaic

mihaic commented Oct 13, 2020

Copy link
Copy Markdown
Member

Because we are planning to make a release very soon, I will add @snastase's commits to this PR and merge it.

@me-sh

me-sh commented Oct 13, 2020

Copy link
Copy Markdown
Contributor Author

Thanks @snastase and @mihaic !

@mihaic
mihaic merged commit 42f1119 into brainiak:master Oct 14, 2020
@mihaic

mihaic commented Oct 14, 2020

Copy link
Copy Markdown
Member

No, thank you, @me-sh! :)

And thanks for the quick help, @snastase.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants