Skip to content

Fix tfa.py bug: from miter to max_iter as indicated in issue #507 #508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
juanmed wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix tfa.py bug: from miter to max_iter as indicated in issue #507 #508

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions brainiak/factoranalysis/tfa.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,7 +150,7 @@ def __init__(
max_num_voxel=5000,
seed=100,
verbose=False):
self.miter = max_iter
self.max_iter = max_iter
self.threshold = threshold
self.K = K
self.nlss_method = nlss_method
Expand Down Expand Up @@ -858,7 +858,7 @@ def _fit_tfa(self, data, R, template_prior=None):
inner_converged = False
np.random.seed(self.seed)
n = 0
while n < self.miter and not inner_converged:
while n < self.max_iter and not inner_converged:
self._fit_tfa_inner(
data,
R,
Expand Down