Merged
Conversation
Set runs on for conda build to use macos arm runners and python 3.8 through 3.11
Seems like the ARM runners aren't taking jobs.
Member
|
This is great, @davidt0x! Is uploading to PyPI also coming in this PR? |
Contributor
Author
|
Ok, sure, I can add it. sdist only correct? |
Member
|
Yes, please. Only sdist. On a different note, do you know why the main workflow is not triggered by this PR? |
Contributor
Author
|
I am not sure why the workflow didn't run. It does say review required on my end so maybe since it is modifying the workflow it requires review first before running. The workflow ran on my fork fine. |
Contributor
Author
|
Actually, scratch that, I see the problem. I have a YAML syntax error after I uncommented the if statement. Let me fix. |
mihaic
approved these changes
Nov 13, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR implements building of Anaconda and sdist packages for Python 3.8 through 3.10 and uploading to anconda.org and pypi.org on tagged releases. I tried to test the uploading piece as much as possible on my fork but it might need some fixes when it is triggered for the first time.