Skip to content

Fix anaconda release#554

Merged
mihaic merged 7 commits into
masterfrom
fix_release
Nov 25, 2024
Merged

Fix anaconda release#554
mihaic merged 7 commits into
masterfrom
fix_release

Conversation

@davidt0x

Copy link
Copy Markdown
Contributor

The anaconda upload command was just echoing and not actually running. This fix should hopefully work.

@mihaic mihaic enabled auto-merge November 25, 2024 19:20
@mihaic mihaic added this pull request to the merge queue Nov 25, 2024
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to no response for status checks Nov 25, 2024
Need to rework this, removing for now.
@davidt0x

Copy link
Copy Markdown
Contributor Author

I remove the della_notebooks workflow for now, it needs to be reworked anyway with new updates. I don't think it should take much now but I don't want to hold up the release.

@mihaic mihaic enabled auto-merge (squash) November 25, 2024 22:09
@mihaic

mihaic commented Nov 25, 2024

Copy link
Copy Markdown
Member

I think it the issue was the merge queue. I disabled it. If we ever want to re-enable it, we should add merge_group as a workflow triggering event, otherwise required checks will not run to satisfy the queue:
https://docs.github.com/en/repositories/configuring-branches-and-merges-in-your-repository/configuring-pull-request-merges/managing-a-merge-queue#triggering-merge-group-checks-with-github-actions

@mihaic mihaic merged commit 5321d4a into master Nov 25, 2024
@mihaic mihaic deleted the fix_release branch November 25, 2024 22:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants