Merged
Conversation
run workflow on push
I think the conditional in the workflow for releases was wrong. This is what it shoule be. See here for example: https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67
Upload command was just echoing.
mihaic
approved these changes
Nov 25, 2024
Need to rework this, removing for now.
Contributor
Author
|
I remove the della_notebooks workflow for now, it needs to be reworked anyway with new updates. I don't think it should take much now but I don't want to hold up the release. |
Member
|
I think it the issue was the merge queue. I disabled it. If we ever want to re-enable it, we should add |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The anaconda upload command was just echoing and not actually running. This fix should hopefully work.