Merged
Conversation
run workflow on push
I think the conditional in the workflow for releases was wrong. This is what it shoule be. See here for example: https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67
mihaic
approved these changes
Nov 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think I screwed up the conditional for publishing releases. I think its supposed to be like this. Basing it off of https://github.com/scientific-python/cookie/blob/c7b897cf4f2f4d8f374d112d1fc694d92a2793a7/%7B%7Bcookiecutter.project_name%7D%7D/.github/workflows/%7B%25%20if%20cookiecutter.__type%3D%3D'compiled'%20%25%7Dcd.yml%7B%25%20endif%20%25%7D#L67
This should allow it to be triggered by clicking creating a new release through the github page.