Conversation
|
Overall patch LGTM. Would you mind to split the shebang changes and the whitespace fixes into separate commits? It's somewhat good practice to avoid mixing such changes whenever possible. |
|
Thanks; what are the drawbacks to using env? I know we discussed it for another repo years ago as someone was proposing a similar change, but I don't have the reference handy. |
Whoops, missed that. Yes I will spilt the commit.
Thats a good question. Of course there are drawbacks, but I think they do not outweigh the portability for most of the users in my opionion. Today I learned that OpenBSD env does not have this option, same for Solaris/Illumos as far as I read the man pages. |
First of all: Thank you for this cool project!
Motiviation:
This change should improve portability, e.g. when perl is installed to /opt/bin/.
I am using this patch and thought this might be helpful for others, too.