token usage for act - #636
Merged
Merged
Conversation
🦋 Changeset detectedLatest commit: e3e24de The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Contributor
There was a problem hiding this comment.
PR Summary
This PR introduces a new fromAct parameter to track token usage when observations are triggered from an act. The parameter is properly propagated through observeHandler, inference, and actHandler for correct metrics logging.
- In /lib/handlers/observeHandler.ts, the
observemethod now acceptsfromActand updates metrics usingStagehandFunctionName.ACTwhen applicable. - In /lib/inference.ts,
fromActadjusts log file prefixes and summary keys for accurate token tracking. - In /lib/handlers/actHandler.ts, observe calls set
fromActto true, ensuring consistent behavior. - End-to-end eval tests are recommended to verify these updates.
3 file(s) reviewed, no comment(s)
Edit PR Review Bot Settings | Greptile
kamath
approved these changes
Apr 5, 2025
kamath
left a comment
Contributor
There was a problem hiding this comment.
i see the drawbacks here, but ig we can deal with that once it starts to become a pain
Merged
felipeofdev-ai
pushed a commit
to felipeofdev-ai/stagehand
that referenced
this pull request
Aug 4, 2026
* token usage for act * changeset
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
what changed
fromActparameter from within act handler -> observe handler -> observe inference ifobserveis being called insideacttest plan