feat(inbox): replace visual inbox empty-state text with a dimmed bell - #834
Merged
Merged
Conversation
Sample app builds 📱Below you will find the list of the latest versions of the sample apps. It's recommended to always download the latest builds of the sample apps to accurately test the pull request.
|
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## main #834 +/- ##
============================================
- Coverage 69.07% 68.11% -0.96%
- Complexity 838 1658 +820
============================================
Files 149 250 +101
Lines 4601 9396 +4795
Branches 628 1513 +885
============================================
+ Hits 3178 6400 +3222
- Misses 1189 2480 +1291
- Partials 234 516 +282 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
|
Build available to test |
📏 SDK Binary Size Comparison Report
|
The Visual Notification Inbox shipped English copy and accessibility labels that host apps could not translate. The empty state is now the workspace's own bell glyph, dimmed — no text — and every accessibility label is supplied by the host through `NotificationInboxAccessibilityLabels` on the in-app module config. Unconfigured labels are omitted rather than falling back to SDK English, and the unread badge is hidden from TalkBack so a bare count is never appended to an otherwise unnamed bell. The unread-count label is a function so hosts can apply their own plural rules. Labels are read as the inbox renders rather than captured when a composable enters composition, so a host that initializes the SDK later still gets them. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
mahmoud-elmorabea
force-pushed
the
mbl-2366-inbox-a11y-labels
branch
from
September 5, 2026 15:52
51a8110 to
79196d4
Compare
mahmoud-elmorabea
marked this pull request as ready for review
September 5, 2026 15:54
Shahroz16
approved these changes
Sep 7, 2026
Shahroz16
left a comment
Contributor
There was a problem hiding this comment.
The inbox accessibility changes look good. The focused tests pass, and I found no remaining issue in the implementation.
cio-mobile-release Bot
pushed a commit
that referenced
this pull request
Sep 9, 2026
## [4.21.0](4.20.4...4.21.0) (2026-09-09) ### Features * **inbox:** replace visual inbox empty-state text with a dimmed bell ([#834](#834)) ([a6ff2e2](a6ff2e2))
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Removes the Visual Notification Inbox's hardcoded English copy and accessibility labels: the empty state becomes the workspace's own bell glyph (dimmed, no text), and host apps supply any accessibility labels themselves via
InboxAccessibilityLabelson the in-app module config.Pairs with customerio/customerio-ios#1251.
🤖 Generated with Claude Code